Localization issue

[wullemsb]

When testing the Smart Combobox on my local machine, I never got any semantic matches back.

Further investigation showed that the minimal-threshold was incorrectly parsed due to my localization settings(nl-BE).
On my local machine 0.6f was parsed as 6 which is out of the range of supported values(0-1).

In my language the decimal separator is a ',' (comma) and not a '.' (period).

I was able to work around the issue by explicitly setting the locale to en-US:

var defaultCulture = "en-US";
var ci = new CultureInfo(defaultCulture);
app.UseRequestLocalization(new RequestLocalizationOptions
{
    DefaultRequestCulture = new RequestCulture("en-US"),
    SupportedCultures = new List<CultureInfo>
    {
        ci,
    },
    SupportedUICultures = new List<CultureInfo>
    {
        ci,
    }
});

[SteveSandersonMS]

Interesting - thanks! Looks like we need to fix something in the parsing flow to ensure it uses culture-invariant parsing, so it will work regardless of your thread culture.

[SteveSandersonMS]

This should be fixed as of the latest update, 0.1.0-preview10148. If you still encounter similar issues after upgrading, please let us know! Thanks again for reporting it.

[wullemsb]

I'll upgrade and retry. Thanks already!

…

On Fri, Apr 5, 2024 at 10:35 AM Steve Sanderson ***@***.***> wrote: This should be fixed as of the latest update, 0.1.0-preview10148. If you still encounter similar issues after upgrading, please let us know! Thanks again for reporting it. — Reply to this email directly, view it on GitHub <#43 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHKDF7J3BXSJ4SFXMNGDHLY3ZO6ZAVCNFSM6AAAAABFXA2RROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZZGI2DKNBUGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>