Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blazor] call-javascript-from-dotnet.md - pull sample code #33770

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

hakenr
Copy link
Contributor

@hakenr hakenr commented Oct 3, 2024

@hakenr hakenr requested a review from guardrex as a code owner October 3, 2024 11:39
Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guardrex guardrex enabled auto-merge (squash) October 3, 2024 11:40
@guardrex guardrex merged commit 73ade4a into dotnet:main Oct 3, 2024
3 checks passed
@hakenr
Copy link
Contributor Author

hakenr commented Oct 3, 2024

Oops, I forgot to mention that the dotnet/blazor-samples#351 PR hasn't been merged yet. I have another patch for the next CallJsExample8.razor, so I'll push it to blazor-samples and create another PR here to pull both PRs into the docs.

@hakenr hakenr deleted the patch-33 branch October 3, 2024 13:08
@guardrex
Copy link
Collaborator

guardrex commented Oct 3, 2024

That's ok ... no harm. Yes, I forgot that we were waiting on that PR. My head is very much into other things at the moment.

I have another patch for the next CallJsExample8.razor

Sure, but be careful making sample app updates at this time. I have a HUGE 🐘 PR coming for minor sample updates landing later today. Merge conflicts 😈 are possible if you submit a lot of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants