Clarify best app base path (<base> tag) location
#33802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works, I guess. I would've maybe phrased it a bit differently, because declaring the base path before any asset paths (js files, css files, etc.) is mandatory. It doesn't need to be at the start of the head tag, just before any relative paths are referenced. The way you wrote it makes it sound like it's optional. Could be that it's just me. I'd like others to chime in as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33797
Thanks @tobbi! 🚀 ... I'll let this sit until Monday morning to give you a chance to look/comment on it.
Internal previews