Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SDK to .NET 8 #2462

Merged
merged 5 commits into from
Nov 15, 2023
Merged

update SDK to .NET 8 #2462

merged 5 commits into from
Nov 15, 2023

Conversation

adamsitnik
Copy link
Member

Currently it's just a draft. It would be nice to have for #2412, where we would not need to use reflection to figure out whether AVX512 is supported.

@AndreyAkinshin AndreyAkinshin force-pushed the moveToNet8 branch 2 times, most recently from 41966a0 to 65de55d Compare November 15, 2023 11:59
@AndreyAkinshin
Copy link
Member

@adamsitnik I tried to fix issues in this branch, but we have a problem with the Windows GitHub actions workflows. For some reason, it uses the system .NET SDK (C:\Program Files\dotnet\sdk\7.0.403\) instead of ours. I have already explicitly passed our SDK to PATH and BenchmarkDotNet.Build, but it doesn't work. At the moment, I'm out of ideas on how to fix it. =(

@AndreyAkinshin AndreyAkinshin force-pushed the moveToNet8 branch 5 times, most recently from b467e19 to f431dac Compare November 15, 2023 13:11
@adamsitnik
Copy link
Member Author

@AndreyAkinshin thanks for your help!

I would expect 8a02ec2 to fix the problem, but it did not?!?

@AndreyAkinshin AndreyAkinshin force-pushed the moveToNet8 branch 2 times, most recently from 0f48140 to 094287e Compare November 15, 2023 13:39
@AndreyAkinshin
Copy link
Member

@adamsitnik I have found a bug with setting the PATH variable in build.ps1. Now the bug is fixed and build.cmd uses our .NET SDK for all kinds of operations on all OSes. Let's wait for the test run results.

adamsitnik
adamsitnik commented Nov 15, 2023
View reviewed changes
Copy link
Member Author

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it LGTM, I found only some minor nits.

.github/workflows/run-tests.yaml Outdated Show resolved Hide resolved
tests/BenchmarkDotNet.IntegrationTests/BuildTimeoutTests.cs Outdated Show resolved Hide resolved
tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs Outdated Show resolved Hide resolved
@adamsitnik adamsitnik marked this pull request as ready for review November 15, 2023 14:57
@adamsitnik
Copy link
Member Author

@AndreyAkinshin before I've applied my suggestions all CI legs were green! 🥇

@AndreyAkinshin
Copy link
Member

@adamsitnik I have removed all the temporary stuff and cleaned up the history. If all tests are green, feel free to merge the PR, there are no more upcoming updates from my side.

@AndreyAkinshin
Copy link
Member

@adamsitnik everything is green!

@adamsitnik adamsitnik merged commit e903115 into master Nov 15, 2023
12 checks passed
@adamsitnik adamsitnik deleted the moveToNet8 branch November 15, 2023 18:40
@adamsitnik adamsitnik mentioned this pull request Nov 15, 2023
Merged
@AndreyAkinshin AndreyAkinshin added this to the v0.13.11 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyAkinshin AndreyAkinshin AndreyAkinshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.11
Development

Successfully merging this pull request may close these issues.
2 participants
@adamsitnik @AndreyAkinshin