Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multitenancy #3632
Add multitenancy #3632
Changes from 3 commits
f48fc16
c595975
14e027e
fd46d36
b71260b
003f92c
6c12e0a
b73160a
8113036
b51f25f
7159071
2335172
1bab8cd
719c4fd
9c0c6bc
1b7064e
0178943
18c5800
5a73892
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth adding a note about DbContext pooling, which is incompatible with this specific approach, since the constructor is only called when the instance is first created, but the tenant ID needs to be set every time the instance is handed out. This can be done having an IDbContextFactory implementation which references the singleton pooling factory, and sets the tenant it gets from it before returning the context to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tend to show AddDbContext by default as the simpler option, as opposed to AddDbContextFactory - this means user code just gets injected with DbContext instances directly, instead of getting a factory and needing to do the additional step of getting the DbContext (and worrying about disposing it!).
Do you think there's a particular reason to show AddDbContextFactory here?