Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass correct clientId to Unsubscribe interceptor #1631

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Pass correct clientId to Unsubscribe interceptor #1631

merged 1 commit into from
Dec 23, 2022

Conversation

ghord
Copy link
Contributor

@ghord ghord commented Dec 18, 2022

Currently InterceptingUnsubscriptionEventArgs passed to Unsubscription interceptor has Topic instead of desired ClientId. This commit fixes the issue, by passing the same _session.Id value as for InterceptingSubscriptionEventArgs

@SeppPenner
Copy link
Collaborator

Looks correct for me.

@chkr1011
Copy link
Collaborator

Thank you for your contribution. Good work 👍

@chkr1011 chkr1011 merged commit abe7bbd into dotnet:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chkr1011 chkr1011 Awaiting requested review from chkr1011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghord @SeppPenner @chkr1011