Change F# AssemblyInfo generation to always include a do() after the … #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version attributes
ChrisPulman
referenced
this pull request
in reactiveui/ReactiveUI
Jun 14, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Nerdbank.GitVersioning](https://github.com/dotnet/Nerdbank.GitVersioning) | `3.6.133` -> `3.6.139` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dotnet/Nerdbank.GitVersioning (Nerdbank.GitVersioning)</summary> ### [`v3.6.139`](https://github.com/dotnet/Nerdbank.GitVersioning/releases/tag/v3.6.139) #### What's Changed - Fix WPF incremental build by [@​AArnott](https://github.com/AArnott) in [https://github.com/dotnet/Nerdbank.GitVersioning/pull/982](https://github.com/dotnet/Nerdbank.GitVersioning/pull/982) - Fix build.ps1 script by [@​AArnott](https://github.com/AArnott) in [https://github.com/dotnet/Nerdbank.GitVersioning/pull/994](https://github.com/dotnet/Nerdbank.GitVersioning/pull/994) - Change F# AssemblyInfo generation to always include a do() after the … by [@​Numpsy](https://github.com/Numpsy) in [https://github.com/dotnet/Nerdbank.GitVersioning/pull/1024](https://github.com/dotnet/Nerdbank.GitVersioning/pull/1024) #### New Contributors - [@​Numpsy](https://github.com/Numpsy) made their first contribution in [https://github.com/dotnet/Nerdbank.GitVersioning/pull/1024](https://github.com/dotnet/Nerdbank.GitVersioning/pull/1024) **Full Changelog**: dotnet/Nerdbank.GitVersioning@v3.6.133...v3.6.139 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/reactiveui/ReactiveUI). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJEZXBlbmRlbmN5IE1hbmFnZW1lbnQiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…version attributes
Fixes #1022
As it stands, assembly version information for F# when ThisAssembly generation is disabled generates things like
because the
do()after the attributes is required and isn't added.There is a unit test for this case, but I don't think it's quite right as it expects the
do()to be a header for the#if NETSTANDARD || NETFRAMEWORK || NETCOREAPPbit instead of a footer for the assembly version attributes.