Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce NBGV_UseAssemblyVersionInNativeVersion msbuild property #1125

Merged

Conversation

vitezslav-popovsky-solarwinds
Copy link
Contributor

@vitezslav-popovsky-solarwinds vitezslav-popovsky-solarwinds commented Dec 8, 2024

The new NBGV_UseAssemblyVersionInNativeVersion switch allows user to choose whether AssemblyVersion (default) or AssemblyFileVersion is used as a source for PRODUCTVERSION

VS_VERSION_INFO VERSIONINFO
FILEVERSION NBGV_FILE_MAJOR_VERSION,NBGV_FILE_MINOR_VERSION,NBGV_FILE_BUILD_VERSION,NBGV_FILE_REVISION_VERSION
PRODUCTVERSION NBGV_PRODUCT_MAJOR_VERSION,NBGV_PRODUCT_MINOR_VERSION,NBGV_PRODUCT_BUILD_VERSION,NBGV_PRODUCT_REVISION_VERSION
FILEFLAGSMASK 0x3FL

@vitezslav-popovsky-solarwinds
Copy link
Contributor Author

vitezslav-popovsky-solarwinds commented Dec 8, 2024

@dotnet-policy-service agree

@AArnott AArnott added this to the v3.7 milestone Dec 9, 2024
@AArnott AArnott merged commit 36a4796 into dotnet:main Dec 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants