Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix telemetry flow #3054

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

deepchoudhery
Copy link
Member

issue started with first time dotnet-scaffold use not detecting any categories, delved deeper and found a bunch of issues.

  1. dotnet-scaffold-aspnet and dotnet-scaffold-aspire first time sentinel files were being created even when invoked through dotnet-scaffold.
  2. led to environment variable TelemetryConstants.DOTNET_SCAFFOLD_TELEMETRY_STATE not being passed correctly. Passing it in all dotnet invocations now.
  3. this subsequently fixed the issue at the top, since first time sentinel text was being presented instead of the appropriate get-commands result

@deepchoudhery deepchoudhery self-assigned this Oct 29, 2024
@tlmii
Copy link
Member

tlmii commented Oct 29, 2024

/azp run

@tlmii
Copy link
Member

tlmii commented Oct 29, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@deepchoudhery deepchoudhery merged commit fd64143 into main Oct 29, 2024
8 checks passed
@deepchoudhery deepchoudhery deleted the dev/decho/fix-first-time-telemetry-flow branch October 29, 2024 18:14
@deepchoudhery
Copy link
Member Author

/backport to release/9.0

Copy link

Started backporting to release/9.0: https://github.com/dotnet/Scaffolding/actions/runs/11580361411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants