Add scaffolding for pool throttling #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n connection string options.
mdaigle
commented
Jul 11, 2024
| } | ||
| } | ||
|
|
||
| private bool IsBlockingPeriodEnabled() |
There was a problem hiding this comment.
carried over verbatim from DbConnectionPool
mdaigle
commented
Jul 11, 2024
| @@ -40,14 +36,10 @@ protected override SqlConnectionX CreateDbConnection() | |||
|
|
|||
| internal SqlDataSource( | |||
| SqlConnectionStringBuilder connectionStringBuilder, | |||
| SqlCredential credential, | |||
| RemoteCertificateValidationCallback userCertificateValidationCallback, | |||
There was a problem hiding this comment.
removing these for now until we fully implement additional auth pathways
mdaigle
requested review from
VladimirReshetnikov,
benrr101,
saurabh500,
cheenamalhotra and
samsharma2700
edwardneal
reviewed
Jul 12, 2024
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/PoolingDataSource.cs
Outdated
Show resolved
Hide resolved
....Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/ConcurrencyRateLimiter.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/SqlDataSourceBuilder.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/IRateLimiter.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/SqlDataSourceBuilder.cs
Outdated
Show resolved
Hide resolved
...ta.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/BlockingPeriodRateLimiter.cs
Outdated
Show resolved
Hide resolved
....Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/ConcurrencyRateLimiter.cs
Outdated
Show resolved
Hide resolved
edwardneal
reviewed
Jul 13, 2024
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/PoolingDataSource.cs
Outdated
Show resolved
Hide resolved
benrr101
reviewed
Jul 15, 2024
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/PoolingDataSource.cs
Outdated
Show resolved
Hide resolved
...Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/AsyncFlagFunc.cs
Outdated
Show resolved
Hide resolved
...ta.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/BlockingPeriodRateLimiter.cs
Outdated
Show resolved
Hide resolved
....Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/ConcurrencyRateLimiter.cs
Outdated
Show resolved
Hide resolved
....Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/ConcurrencyRateLimiter.cs
Outdated
Show resolved
Hide resolved
....Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/PassthroughRateLimiter.cs
Outdated
Show resolved
Hide resolved
....Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/PassthroughRateLimiter.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/RateLimiterBase.cs
Outdated
Show resolved
Hide resolved
| /// <param name="async">Whether this method should run asynchronously.</param> | ||
| /// <param name="cancellationToken">Cancels outstanding requests.</param> | ||
| /// <returns>Returns the result of the callback or the next rate limiter.</returns> | ||
| internal abstract ValueTask<TResult> Execute<State, TResult>(AsyncFlagFunc<State, ValueTask<TResult>> callback, State state, bool async, CancellationToken cancellationToken = default); |
There was a problem hiding this comment.
I'm wondering - using a delegate here might introduce some overhead we can avoid. I'm going to try a quick benchmark test to verify what I'm thinking, let me get back to you.
There was a problem hiding this comment.
Based on @benrr101 's benchmarking, delegates are the slowest (compared to lambdas and concrete functions). I'll give this setup some thought as I implement the logic of the callback to see if this setup still makes sense or if we can switch to something more performant while still preserving the intent of the interface we expose to the rate limiters.
VladimirReshetnikov
approved these changes
Jul 15, 2024
...Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/AsyncFlagFunc.cs
Outdated
Show resolved
Hide resolved
...ta.SqlClient/netcore/src/Microsoft/Data/SqlClientX/RateLimiters/BlockingPeriodRateLimiter.cs
Outdated
Show resolved
Hide resolved
benrr101
approved these changes
Jul 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a mechanism for throttling enforcement within the connection pool. Basic passthrough and concurrency limiters are included. Focusing on the high throughput case (no rate limit), so I will add a backlog work item to implement the pool blocking period rate limiter.