Cleanup | SNI Native Wrapper #3056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benrr101
added
➕ Code Health
benrr101
requested review from
saurabh500,
mdaigle,
cheenamalhotra,
David-Engel and
samsharma2700
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3056 +/- ##
==========================================
+ Coverage 72.66% 72.70% +0.04%
==========================================
Files 283 283
Lines 58975 58934 -41
==========================================
- Hits 42853 42848 -5
+ Misses 16122 16086 -36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mdaigle
approved these changes
Dec 5, 2024
| SqlClientEventSource.Log.TryNotificationTraceEvent("<sc.SqlDependency.ObtainProcessDispatcher|DEP|ERR> ERROR - AppDomain.CreateInstance returned null!"); | ||
| throw ADP.InternalError(ADP.InternalErrorCode.SqlDependencyProcessDispatcherFailureCreateInstance); | ||
| SqlClientEventSource.Log.TryNotificationTraceEvent("<sc.SqlDependency.ObtainProcessDispatcher|DEP|ERR> ERROR - ObjectHandle.Unwrap returned null!"); | ||
| throw ADP.InternalError(ADP.InternalErrorCode.SqlDependencyObtainProcessDispatcherFailureObjectHandle); |
There was a problem hiding this comment.
The net change here will result in a different error code (and trace message), but I think the change makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This is a followup to the SNI Native Wrapper code merge. Each commit in this PR is an atomic change, so if the PR gets too cluttered to review all up, it can be stepped through one commit at a time. Most of these changes are just renaming and moving code around. One larger change is removing a bunch of private methods that were no longer necessary after extracting the DLL imports (as mentioned by @edwardneal).
Testing: There aren't really any functional changes here, so CI pass should be sufficient validation.