-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Fix unsigned artifact uploading #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit de30a7e added conditions to skip signing on PR builds, but it did not produce a valid toolchain artifact. Fix this by updating the zip task to always run and produce something to upload.
grendello
approved these changes
Feb 29, 2024
grendello
added a commit
that referenced
this pull request
Feb 29, 2024
* main: [ci] Fix unsigned artifact uploading (#13)
grendello
added a commit
to dotnet/android
that referenced
this pull request
Mar 13, 2024
Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.1.1 Changes: dotnet/android-native-tools@L_17.0.6-7.1.0...L_17.0.6-7.1.1 This release is identical to the previous one, version wise, with the difference being a handful of new build and link flags, as required by API Scan. * [ci] Build and sign in a DevDiv pipeline by @pjcollins in dotnet/android-native-tools#7 * [ci] Migrate to the 1ES template by @pjcollins in dotnet/android-native-tools#8 * [ci] Improve binskim scan performance by @pjcollins in dotnet/android-native-tools#11 * [ci] Improve triggers and support test signing by @pjcollins in dotnet/android-native-tools#12 * [ci] Fix unsigned artifact uploading by @pjcollins in dotnet/android-native-tools#13 * [ci] Disable automatic GitHub action trigger by @pjcollins in dotnet/android-native-tools#16 * [ci] Build on performance build pools by @pjcollins in dotnet/android-native-tools#15 * Build `as.exe` on windows by @grendello in dotnet/android-native-tools#10 * [ci] Add API Scan job by @pjcollins in dotnet/android-native-tools#9
grendello
added a commit
to dotnet/android
that referenced
this pull request
Apr 2, 2024
Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.1.1 Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.1.2 Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.2.1 Changes: dotnet/android-native-tools@L_17.0.6-7.1.0...L_17.0.6-7.1.1 Changes: dotnet/android-native-tools@L_17.0.6-7.1.1...L_17.0.6-7.1.2 Changes: dotnet/android-native-tools@L_17.0.6-7.1.2...L_17.0.6-7.2.0 Changes: dotnet/android-native-tools@L_17.0.6-7.2.0...L_17.0.6-7.2.1 This release makes changes to how we build and run the `as.exe` wrapper, so that it can be verified by API Scan without any issues. Otherwise it is identical to the previous release, using the same version of LLVM. * [ci] Build and sign in a DevDiv pipeline by @pjcollins in dotnet/android-native-tools#7 * [ci] Migrate to the 1ES template by @pjcollins in dotnet/android-native-tools#8 * [ci] Improve binskim scan performance by @pjcollins in dotnet/android-native-tools#11 * [ci] Improve triggers and support test signing by @pjcollins in dotnet/android-native-tools#12 * [ci] Fix unsigned artifact uploading by @pjcollins in dotnet/android-native-tools#13 * [ci] Disable automatic GitHub action trigger by @pjcollins in dotnet/android-native-tools#16 * [ci] Build on performance build pools by @pjcollins in dotnet/android-native-tools#15 * Build `as.exe` on windows by @grendello in dotnet/android-native-tools#10 * [ci] Add API Scan job by @pjcollins in dotnet/android-native-tools#9 * Fix `as.exe` crash on Windows by @grendello in dotnet/android-native-tools#20 * [ci] Use managed identity for API Scan by @pjcollins in dotnet/android-native-tools#21 * Back to wide strings on Windows + magic encantations by @grendello in dotnet/android-native-tools#22
grendello
added a commit
to dotnet/android
that referenced
this pull request
Apr 11, 2024
Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.1.1 Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.1.2 Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.2.1 Changes: dotnet/android-native-tools@L_17.0.6-7.1.0...L_17.0.6-7.1.1 Changes: dotnet/android-native-tools@L_17.0.6-7.1.1...L_17.0.6-7.1.2 Changes: dotnet/android-native-tools@L_17.0.6-7.1.2...L_17.0.6-7.2.0 Changes: dotnet/android-native-tools@L_17.0.6-7.2.0...L_17.0.6-7.2.1 This release makes changes to how we build and run the `as.exe` wrapper, so that it can be verified by API Scan without any issues. Otherwise it is identical to the previous release, using the same version of LLVM. * [ci] Build and sign in a DevDiv pipeline by @pjcollins in dotnet/android-native-tools#7 * [ci] Migrate to the 1ES template by @pjcollins in dotnet/android-native-tools#8 * [ci] Improve binskim scan performance by @pjcollins in dotnet/android-native-tools#11 * [ci] Improve triggers and support test signing by @pjcollins in dotnet/android-native-tools#12 * [ci] Fix unsigned artifact uploading by @pjcollins in dotnet/android-native-tools#13 * [ci] Disable automatic GitHub action trigger by @pjcollins in dotnet/android-native-tools#16 * [ci] Build on performance build pools by @pjcollins in dotnet/android-native-tools#15 * Build `as.exe` on windows by @grendello in dotnet/android-native-tools#10 * [ci] Add API Scan job by @pjcollins in dotnet/android-native-tools#9 * Fix `as.exe` crash on Windows by @grendello in dotnet/android-native-tools#20 * [ci] Use managed identity for API Scan by @pjcollins in dotnet/android-native-tools#21 * Back to wide strings on Windows + magic encantations by @grendello in dotnet/android-native-tools#22
jonathanpeppers
pushed a commit
to dotnet/android
that referenced
this pull request
May 8, 2024
Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.1.1 Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.1.2 Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.2.1 Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.2.2 Changes: dotnet/android-native-tools@L_17.0.6-7.1.0...L_17.0.6-7.1.1 Changes: dotnet/android-native-tools@L_17.0.6-7.1.1...L_17.0.6-7.1.2 Changes: dotnet/android-native-tools@L_17.0.6-7.1.2...L_17.0.6-7.2.0 Changes: dotnet/android-native-tools@L_17.0.6-7.2.0...L_17.0.6-7.2.1 Changes: dotnet/android-native-tools@L_17.0.6-7.2.1...L_17.0.6-7.2.2 This release makes changes to how we build and run the `as.exe` wrapper, so that it can be verified by API Scan without any issues. Otherwise it is identical to the previous release, using the same version of LLVM. * [ci] Build and sign in a DevDiv pipeline by @pjcollins in dotnet/android-native-tools#7 * [ci] Migrate to the 1ES template by @pjcollins in dotnet/android-native-tools#8 * [ci] Improve binskim scan performance by @pjcollins in dotnet/android-native-tools#11 * [ci] Improve triggers and support test signing by @pjcollins in dotnet/android-native-tools#12 * [ci] Fix unsigned artifact uploading by @pjcollins in dotnet/android-native-tools#13 * [ci] Disable automatic GitHub action trigger by @pjcollins in dotnet/android-native-tools#16 * [ci] Build on performance build pools by @pjcollins in dotnet/android-native-tools#15 * Build `as.exe` on windows by @grendello in dotnet/android-native-tools#10 * [ci] Add API Scan job by @pjcollins in dotnet/android-native-tools#9 * Fix `as.exe` crash on Windows by @grendello in dotnet/android-native-tools#20 * [ci] Use managed identity for API Scan by @pjcollins in dotnet/android-native-tools#21 * Back to wide strings on Windows + magic encantations by @grendello in dotnet/android-native-tools#22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit de30a7e added conditions to skip signing on PR builds, but it
did not produce a valid toolchain artifact. Fix this by updating the
zip task to always run and produce something to upload.