ff

dotnet · Jul 26, 2017 · 7a5910c · 7a5910c
1 parent 060b812
commit 7a5910c
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/src/Xamarin.Android.Build.Tasks/Utilities/ManifestDocument.cs b/src/Xamarin.Android.Build.Tasks/Utilities/ManifestDocument.cs
@@ -70,19 +70,17 @@ public string VersionCode {
 				doc.Root.SetAttributeValue (androidNs + "versionCode", value);
 			}
 		}
-		public string MinimumSdk {
-			get {
-				var uses = doc.Root.Element ("uses-sdk");
-				if (uses?.Attribute (androidNs + "minSdkVersion") == null) {
-					int minSdkVersion;
-					if (!int.TryParse (SdkVersionName, out minSdkVersion))
-						minSdkVersion = 11;
-					return Math.Min (minSdkVersion, 11).ToString ();
-				} else {
-					return uses.Attribute (androidNs + "minSdkVersion").Value;
-				}
+		public string GetMinimumSdk () {
+			var minAttr = doc.Root.Element ("uses-sdk")?.Attribute (androidNs + "minSdkVersion");
+			if (minAttr == null) {
+				int minSdkVersion;
+				if (!int.TryParse (SdkVersionName, out minSdkVersion))
+					minSdkVersion = 11;
+				return Math.Min (minSdkVersion, 11).ToString ();
 			}
+			return minAttr.Value;
 		}
+
 		TaskLoggingHelper log;
 
 		public ManifestDocument (string templateFilename, TaskLoggingHelper log) : base ()
@@ -877,7 +875,7 @@ public void CalculateVersionCode (string currentAbi, string versionCodePattern,
 			if (!kvp.ContainsKey ("versionCode"))
 				kvp.Add ("versionCode", int.Parse (VersionCode));
 			if (!kvp.ContainsKey ("minSDK")) {
-				kvp.Add ("minSDK", int.Parse (MinimumSdk));
+				kvp.Add ("minSDK", int.Parse (GetMinimumSdk ()));
 			}
 			var versionCode = String.Empty;
 			foreach (Match match in regex.Matches (versionCodePattern)) {