-
Notifications
You must be signed in to change notification settings - Fork 528
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Xamarin.Android.Build.Tasks] Fix Aapt task to emit warnings (#1178)
Fixes: #1134 Commit 23c5801 reworked `<Aapt/>` to emit warnings if the required output file did exist. If it didn't we should emit errors. There was one slight problem with this, we were checking the wrong file. We should have been checking for the temp `packaged_resources` file rather than `R.txt` (which will always exist after an initial build). This commit fixes that and adds a unit test. Note the in order to create the senario we need to have a `$(TargetFrameworkVersion)` which is `v8.0`. We currently only build `v1.0` and `v8.1` for PR builds. So the test checks to see if that target framework is available. If not the test will be ignored.
- Loading branch information
1 parent
a66e8b8
commit 9372683
Showing
3 changed files
with
40 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters