Skip to content

Commit

Permalink
[One .NET] Do not always preserve Android.Runtime.CharSequence (#5363)
Browse files Browse the repository at this point in the history
Context: #5167

The `Android.Runtime.CharSequence` type is not accessed via reflection.

Allowing `CharSequence` to be linked allows unreferenced members to
be removed by the linker (yay!), e.g. when comparing the `.apk` built
from the `BuildReleaseArm64False` test:

	$ apkdiff before.apk after.apk
	…
	Type Android.Runtime.CharSequence
	  -             Method public static SIGERR ToLocalJniHandle (System.Collections.Generic.IEnumerable`1<char>)
	…

The `Android.Runtime.CharSequence.ToLocalJniHandle()` is removed.
  • Loading branch information
radekdoulik authored Dec 4, 2020
1 parent f58b96d commit a74fe4a
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<assembly fullname="Mono.Android">
<type fullname="Android.Runtime.AndroidEnvironment" />
<type fullname="Android.Runtime.AnnotationAttribute" />
<type fullname="Android.Runtime.CharSequence" />
<type fullname="Android.Runtime.ConstructorBuilder" />
<type fullname="Android.Runtime.GeneratedDummyHost" />
<type fullname="Android.Runtime.GeneratedEnumAttribute" />
Expand Down

0 comments on commit a74fe4a

Please sign in to comment.