Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to stop renaming the Mono.Cecil.dll to Xamarin.Android.Cecil.dll #3132

Closed
radekdoulik opened this issue May 27, 2019 · 0 comments · Fixed by #8489
Closed

Try to stop renaming the Mono.Cecil.dll to Xamarin.Android.Cecil.dll #3132

radekdoulik opened this issue May 27, 2019 · 0 comments · Fixed by #8489
Assignees
@pjcollins

Comments

@radekdoulik
Copy link
Member

Let see whether we can get rid of renaming the Mono.Cecil.dll to Xamarin.Android.Cecil.dll

That would mean we could then use Mono.Cecil.dll from mono SDKs and simplify all the copying and renaming of cecil assemblies.
@radekdoulik radekdoulik self-assigned this May 27, 2019
@jpobst jpobst mentioned this issue Nov 13, 2023
Merged
@pjcollins pjcollins assigned pjcollins and unassigned radekdoulik Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
jonathanpeppers pushed a commit that referenced this issue May 6, 2024
@pjcollins @jonathanpeppers
[build] Stop producing Xamarin.Android.Cecil.dll (#8489)
3e13e92 
Fixes: #3132

Context: xamarin/monodroid@b934949

`Xamarin.Android.Cecil.dll` was created to avoid potential conflicts
and versioning issues with the copy of Cecil that Xamarin Studio was
using at the time; from April 2013:

> The issue is that when Xamarin Studio builds MSBuild-based
> projects, it does so through an intermediary
> `MonoDevelop.Projects.Formats.MSBuild.exe` process, which is
> responsible for using the `Microsoft.Build.*` assemblies to
> actually build the project.
>
> The problem is that the directory containing
> `MonoDevelop.Projects.Formats.MSBuild.exe` --
> `/Applications/Xamarin Studio.app/Contents/MacOS/lib/monodevelop/bin`
> -- contains its own copy of `Mono.Cecil.dll`, and _that_ is the
> version that was used!
>
> Meaning that in order to fix a Xamarin.Android bug, we would need
> an updated Xamarin Studio release.

Considering our migration to .NET, and how infrequently we change our
`Mono.Cecil` reference these days, these potential issues are likely
no longer a concern.

Our unique `Xamarin.Android.Cecil.dll` copy has been removed in favor
of `Mono.Cecil` package references in all projects that depend on it.

Conflicts:
    .external
    src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjcollins pjcollins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[build] Stop producing Xamarin.Android.Cecil.dll dotnet/android
2 participants
@pjcollins @radekdoulik