Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xamarin.Android.Build.Tasks] Ignore AndroidAsset items which are folders. #1190

Merged
merged 3 commits into from
Jan 16, 2018

Commits on Jan 12, 2018

  1. [Xamarin.Android.Build.Tasks] Ignore AndroidAsset items which are fol…

    …ders.
    
    When adding a new subfolder in the IDE (VSForMac) we end up
    with a folder which has a build action of AndroidAsset.
    This causes the copy task to fail with
    
    	Cannot copy <folder> to <destfolder>, as the source file doesn't exist",
    
    This is because we assume that all items in AndroidAsset (and
    AndroidResource) and files. It looks like this is not the case.
    While a work around is easy .. simply remove the item. It does
    require that the user manually update the csproj.
    
    So this commit uses `Directory.Exists` to check to see if the
    item is a directory or not. If it is we skip over it. Otherwise
    its a file so we should copy.
    
    We do this in `Files.cs` but also in `AndroidUpdateResDir.cs`.
    The latter has been changed to output a list of the "Resolved"
    files which will not include any folders.
    dellis1972 committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    550f819 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    76fe2b2 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2018

  1. Configuration menu
    Copy the full SHA
    d6698eb View commit details
    Browse the repository at this point in the history