[Xamarin.Android.Build.Tools] Add $(AndroidSdkPlatformToolsVersion) #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
reviewed
Jan 16, 2018
| @@ -233,6 +233,8 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved. | |||
| <GenerateSerializationAssemblies>Off</GenerateSerializationAssemblies> | |||
|
|
|||
| <AndroidSdkBuildToolsVersion Condition="'$(AndroidSdkBuildToolsVersion)' == ''">23.0.0</AndroidSdkBuildToolsVersion> | |||
| <AndroidSdkPlatformToolsVersion Condition="'$(AndroidSdkPlatformToolsVersion)' == ''">25.0.5</AndroidSdkPlatformToolsVersion> | |||
| <AndroidSdkBuildToolsVersion Condition="'$(AndroidSdkBuildToolsVersion)' == ''">25.2.5</AndroidSdkBuildToolsVersion> | |||
There was a problem hiding this comment.
This property is also specified two lines above.
This PR should alter the existing value, not "replace" it two lines later. :-)
|
Additionally, please add an |
Fixes dotnet#1165 We need to provide default values for `platform-tools` and `tools` so that our SDK Manager can correctly download the required versions.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 21, 2021
Changes: xamarin/monodroid@45abd3f...ed584c7 * xamarin/monodroid@ed584c775: [tools/msbuild] Improve FastDeploy error messages (dotnet#1190) * xamarin/monodroid@74294dca0: Bump to xamarin/androidtools@47ec118f (dotnet#1195) * xamarin/monodroid@ff633623e: [tools/msbuild] Add additional diagnostic logging for FastDev. (dotnet#1194) * xamarin/monodroid@546d5fb58: [tools/msbuild] Add Better Diagnostic Logging for Fast Deployment. (dotnet#1185) * xamarin/monodroid@fa6a1a058: [tools/msbuild] incude PackageName in MAX_COMMAND adb check. (dotnet#1189) * xamarin/monodroid@ac447cb5d: Bump Xamarin.Android to bring in JDK Fixes (dotnet#1192)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 22, 2021
Changes: xamarin/monodroid@ff63362...76c04cd * xamarin/monodroid@76c04cd15 [tools/msbuild] [MSB3680] The source file "obj/Debug/androidx/jl/classes.dex" does not exist (dotnet#1197) * xamarin/monodroid@ed584c775 [tools/msbuild] Improve FastDeploy error messages (dotnet#1190) * xamarin/monodroid@74294dca0 Bump to xamarin/androidtools@47ec118f (dotnet#1195)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 22, 2021
Fixes: dotnet#5863 Changes: xamarin/monodroid@ff63362...76c04cd * xamarin/monodroid@76c04cd15 [tools/msbuild] [MSB3680] The source file "obj/Debug/androidx/jl/classes.dex" does not exist (dotnet#1197) * xamarin/monodroid@ed584c775 [tools/msbuild] Improve FastDeploy error messages (dotnet#1190) * xamarin/monodroid@74294dca0 Bump to xamarin/androidtools@47ec118f (dotnet#1195)
jonpryor
added a commit
that referenced
this pull request
Apr 26, 2021
Fixes: #5863 Changes: xamarin/monodroid@ff63362...76c04cd * xamarin/monodroid@76c04cd15 [tools/msbuild] [MSB3680] The source file "obj/Debug/androidx/jl/classes.dex" does not exist (#1197) * xamarin/monodroid@ed584c775 [tools/msbuild] Improve FastDeploy error messages (#1190) * xamarin/monodroid@74294dca0 Bump to xamarin/androidtools@47ec118f (#1195)
jonathanpeppers
pushed a commit
that referenced
this pull request
Apr 26, 2021
Fixes: #5863 Changes: xamarin/monodroid@ff63362...76c04cd * xamarin/monodroid@76c04cd15 [tools/msbuild] [MSB3680] The source file "obj/Debug/androidx/jl/classes.dex" does not exist (#1197) * xamarin/monodroid@ed584c775 [tools/msbuild] Improve FastDeploy error messages (#1190) * xamarin/monodroid@74294dca0 Bump to xamarin/androidtools@47ec118f (#1195)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1165
We need to provide default values for
platform-toolsandtoolsso that our SDK Manager can correctly downloadthe required versions.