Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Override default yaml checkout behavior #3157

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

pjcollins
Copy link
Member

We're hitting a couple of git related issues on certain machines, most
commonly around submodule updating on Windows. Rather than relying on an
msbuild setup task to do this, we should override the default pipeline
source checkout behavior. We'll now fetch a clean tree and recursively
clone all relevant submodules for each build stage.

We're hitting a couple of git related issues on certain machines, most
commonly around submodule updating on Windows. Rather than relying on an
msbuild setup task to do this, we should override the default pipeline
source checkout behavior. We'll now fetch a clean tree and recursively
clone all relevant submodules for each build stage.
@pjcollins pjcollins requested a review from jonpryor as a code owner May 31, 2019 20:30
@jonathanpeppers jonathanpeppers self-requested a review May 31, 2019 20:41
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I had these settings set on the old “Xamarin.Android (Windows)” job.

@jonathanpeppers
Copy link
Member

Well, we got past the git checkout, but there is new breakage from 055dabe:

"E:\A\_work\2218\s\tests\Runtime-MultiDex\Mono.Android-TestsMultiDex.csproj" (default target) (38) ->
(_ConvertPdbFiles target) -> 
  E:\A\_work\2218\s\bin\Release\lib\xamarin.android\xbuild\Xamarin\Android\Xamarin.Android.Common.targets(2060,2): warning : Could not load file or assembly 'Mono.CompilerServices.SymbolWriter, Version=4.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756' or one of its dependencies. The system cannot find the file specified. [E:\A\_work\2218\s\tests\Runtime-MultiDex\Mono.Android-TestsMultiDex.csproj]
E:\A\_work\2218\s\bin\Release\lib\xamarin.android\xbuild\Xamarin\Android\Xamarin.Android.Common.targets(2060,2): warning :    at Pdb2Mdb.Converter.Convert(String filename) [E:\A\_work\2218\s\tests\Runtime-MultiDex\Mono.Android-TestsMultiDex.csproj]
E:\A\_work\2218\s\bin\Release\lib\xamarin.android\xbuild\Xamarin\Android\Xamarin.Android.Common.targets(2060,2): warning :    at Xamarin.Android.Tasks.ConvertDebuggingFiles.Execute() [E:\A\_work\2218\s\tests\Runtime-MultiDex\Mono.Android-TestsMultiDex.csproj]

@pjcollins
Copy link
Member Author

pjcollins commented May 31, 2019

Yeah, I think we should try to get this and #3158 in asap to help stabilize things.

@jonpryor jonpryor merged commit 7768eec into master Jun 1, 2019
@pjcollins pjcollins deleted the yaml-checkout-submodules branch June 1, 2019 03:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants