[illink] Do not preserve A.R.AndroidEnvironment #5362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of dotnet#5167 Removed API from `BuildReleaseArm64False` test: Type Android.Runtime.AndroidEnvironment - Field public static string AndroidLogAppName - Field static Javax.Net.Ssl.IX509TrustManager sslTrustManager - Field static Java.Security.KeyStore certStore - Method static SIGERR SetupTrustManager () - Method static SIGERR SetupCertStore () - Method public static SIGERR add_UnhandledExceptionRaiser (System.EventHandler`1<Android.Runtime.RaiseThrowableEventArgs>) - Method public static SIGERR remove_UnhandledExceptionRaiser (System.EventHandler`1<Android.Runtime.RaiseThrowableEventArgs>) - Method static SIGERR TrustEvaluateSsl (System.Collections.Generic.List`1<byte[]>) - Method static SIGERR CertStoreLookup (long, bool) - Method static SIGERR GetX509CertificateFactory () - Method static SIGERR ConvertCertificate (Java.Security.Cert.CertificateFactory, byte[]) - Method static SIGERR NotifyTimeZoneChanged () - Method static SIGERR GetDisplayDPI (float&, float&) - Method static SIGERR GetDefaultTimeZone () - Method static SIGERR _monodroid_timezone_get_default_id () - Method static SIGERR GetDefaultSyncContext () - Method static SIGERR _monodroid_getifaddrs (IntPtr&) - Method static SIGERR GetInterfaceAddresses (IntPtr&) - Method static SIGERR _monodroid_freeifaddrs (IntPtr) - Method static SIGERR FreeInterfaceAddresses (IntPtr) - Method static SIGERR _monodroid_detect_cpu_and_architecture (ushort&, ushort&, byte&) - Method static SIGERR DetectCPUAndArchitecture (ushort&, ushort&, bool&) - Method static SIGERR GetDefaultProxy () - Method static SIGERR GetHttpMessageHandler () - Type _Proxy Some of the removed API is obsolete on .NET5/6. Opened dotnet#5361 for it. The template tests run OK on device after the removal.
|
Silly question: why is Doubly odd is that that many of those |
It was result of workaround for signature reader bug in apkdiff. It is just replacement of return type and is no longer an issue in apkdiff anymore. |
jonpryor
pushed a commit
that referenced
this pull request
Dec 10, 2020
Context: #5167 Some members of `Android.Runtime.JNIEnv` are accessed via Reflection, and need to be preserved, but that doesn't mean the *entire type* needs to be preserved. Update the `<type/>` preservation XML so that only the required methods are always preserved, allowing the linker to remove other unused members.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5167
Removed API from
BuildReleaseArm64Falsetest (ignore the SIGERR's in place of return types):Some of the removed API is obsolete on .NET5/6. Opened #5361
for it.
The template tests run OK on device after the removal.