Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to aapt2 4.1.1-6503028 #5412

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Dec 14, 2020

Context: https://mvnrepository.com/artifact/com.android.tools.build/aapt2/4.1.1-6503028
Context: https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/tools/aapt2/

The result of aapt2 version changed:

-Android Asset Packaging Tool (aapt) 2.19-6051327
+Android Asset Packaging Tool (aapt) 2.19-6503028

The best release note I could find are:

https://android.googlesource.com/platform/frameworks/base/+/master/tools/aapt2/readme.md

However, I don't see how any of these map to the versions on Maven:

-compile group: 'com.android.tools.build', name: 'aapt2', version: '4.0.0-6051327', ext: 'pom'
+compile group: 'com.android.tools.build', name: 'aapt2', version: '4.1.1-6503028', ext: 'pom'

Context: https://mvnrepository.com/artifact/com.android.tools.build/aapt2/4.1.1-6503028
Context: https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/tools/aapt2/

The result of `aapt2 version` changed:

    -Android Asset Packaging Tool (aapt) 2.19-6051327
    +Android Asset Packaging Tool (aapt) 2.19-6503028

The best release note I could find are:

https://android.googlesource.com/platform/frameworks/base/+/master/tools/aapt2/readme.md

However, I don't see how any of these map to the versions on Maven:

    -compile group: 'com.android.tools.build', name: 'aapt2', version: '4.0.0-6051327', ext: 'pom'
    +compile group: 'com.android.tools.build', name: 'aapt2', version: '4.1.1-6503028', ext: 'pom'
@jonathanpeppers jonathanpeppers marked this pull request as ready for review December 14, 2020 20:50
@jonathanpeppers jonathanpeppers merged commit 425fc07 into dotnet:master Dec 15, 2020
@jonathanpeppers jonathanpeppers deleted the aapt2-4.1.1 branch December 15, 2020 14:24
jonpryor added a commit that referenced this pull request Mar 17, 2021
This reverts commit 425fc07.

Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1288832
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1287930

We have reports of `aapt2.exe` behaving "weirdly" when running on
certain AMD Phenom II CPUs, either crashing or hanging.

The behavior is new with d16-9.

Revert to the `aapt2` used with d16-8.
jonpryor added a commit that referenced this pull request Mar 29, 2021
This reverts commit 425fc07.

Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1288832
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1287930

We have reports of `aapt2.exe` behaving "weirdly" when running on
certain AMD Phenom II CPUs, either crashing or hanging.

The behavior is new with d16-9.

Revert to the `aapt2` used with d16-8.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants