[One .NET] remove NuGet workarounds #5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this will actually work yet, I get errors building |
|
This is mostly green, but new Are we supposed to do something that excludes these? Question for next week. |
|
I'm going to wait on: #5977 Then come back to this. |
Fixes: dotnet#5896 Since early in .NET 5 development, we had workarounds (hacks?) for enabling the legacy Xamarin.Forms NuGet package to work correctly. We used `$(PackageTargetFallback)` so that `monoandroid` assemblies would be used in NuGet packages. We also had to fix up item groups manually so `monoandroid` could be chosen over `netstandard`. We should be able to remove these workarounds, since we now have a dotnet/installer with this change: NuGet/NuGet.Client@1027428
jonathanpeppers
force-pushed
the
remove-nuget-hacks
branch
from
a43e5d4
to
4d049fc
Compare
|
Only error I'm seeing in the latest run: I think it is unrelated. |
dellis1972
approved these changes
Jun 4, 2021
jonathanpeppers
added a commit
that referenced
this pull request
Jun 4, 2021
Fixes: #5896 Since early in .NET 5 development, we had workarounds (hacks?) for enabling the legacy Xamarin.Forms NuGet package to work correctly. We used `$(PackageTargetFallback)` so that `monoandroid` assemblies would be used in NuGet packages. We also had to fix up item groups manually so `monoandroid` could be chosen over `netstandard`. We should be able to remove these workarounds, since we now have a dotnet/installer with this change: NuGet/NuGet.Client@1027428
jonathanpeppers
added a commit
that referenced
this pull request
Jun 8, 2021
This reverts commit 2ed1339.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5896
Since early in .NET 5 development, we had workarounds (hacks?) for
enabling the legacy Xamarin.Forms NuGet package to work correctly. We
used
$(PackageTargetFallback)so thatmonoandroidassemblies wouldbe used in NuGet packages. We also had to fix up item groups manually
so
monoandroidcould be chosen overnetstandard.We should be able to remove these workarounds, since we now have a
dotnet/installer with this change:
NuGet/NuGet.Client@1027428