-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mono.Android] Bind Android 12L Beta 1. #6601
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
eb6da19
[Mono.Android] Bind Android 12L Beta 1.
jpobst 38fddb7
Drop API 31 packs & remove android-32 workload
jonathanpeppers 44b46d3
[test] update MauiTargetFramework that asserts unstable 32
jonathanpeppers b6dbc98
Bump to build-tools 32.0.0
jonathanpeppers fa1414c
More test changes for API 32
jonathanpeppers 09bab03
Merge branch 'main' into api-32-beta1
jonathanpeppers 4879ac0
[tests] drop SupportedOSPlatformVersion(32) test
jonathanpeppers 22c5ecd
Install build-tools 30.0.3 alongside 32.0.0
jonathanpeppers 20220e3
[One .NET] keep API 31 the default
jonathanpeppers 0f92ce4
[tests] temporarily hardcode targetSdkVersion="31" in .NET tests
jonathanpeppers 2103268
More test fixes when API 31 is default for .NET 6
jonathanpeppers bba5393
Merge branch 'main' into api-32-beta1
jonathanpeppers cade0cb
[xaprepare] check if $(XABuildTools30Version) is blank
jonathanpeppers 5f66c36
Fixes for AndroidDependenciesTests
jonathanpeppers 18bffbb
Merge branch 'main' into api-32-beta1
jonathanpeppers bedecc2
<TargetFrameworkVersion>$(AndroidLatestStableFrameworkVersion)</Targe…
jonathanpeppers 702df8c
Review feedback
jonathanpeppers f24ea83
Didn't hit build!
jonathanpeppers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be using
$(AndroidTargetDotNetApiLevel)
(and possibly other new properties)? Isn't that what$(AndroidTargetDotNetApiLevel)
is for?Related: instead of
$(AndroidTargetDotNetApiLevel)
, should we call it$(AndroidDefaultTargetDotnetApiLevel)
? This "emphasizes" the "default" nature of this value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some of the other tests here, I'll try to use
$(AndroidDefaultTargetDotnetApiLevel)
so we don't have to change them again later.In this case, however, the number 31 needs to remain, it will need to eternally pull this version from NuGet (or our workload):
https://github.com/xamarin/xamarin-android/blob/bedecc25f93a82ecaa8df5cb4e92424aa669125d/build-tools/create-packs/Microsoft.Android.Sdk.proj#L122-L125
I guess that over time, we'll have numbers listed for 32, 33, and so on. We can also update those packs at some point if ever needed (hopefully not ever?), we'd just list a different version number here.