Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/installer #7217

Merged
merged 18 commits into from
Aug 8, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 28, 2022

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.ILLink.Tasks: from 7.0.100-1.22368.1 to 7.0.100-1.22377.1 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NETCore.App.Ref: from 7.0.0-rc.1.22367.4 to 7.0.0-rc.1.22403.8 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NET.Workload.Emscripten.Manifest-7.0.100: from 7.0.0-rc.1.22362.2 to 7.0.0-rc.1.22368.1 (parent: Microsoft.NETCore.App.Ref)

From https://github.com/dotnet/installer

  • Subscription: 97ee8954-2ef3-4217-5719-08da2edb85ba
  • Build: 20220807.1
  • Date Produced: August 8, 2022 2:44:04 AM UTC
  • Commit: 8f639696e6d57fb09e03e89c6397d913de1231ed
  • Branch: refs/heads/main

…220728.5

Microsoft.Dotnet.Sdk.Internal
 From Version 7.0.100-rc.1.22374.1 -> To Version 7.0.100-rc.1.22378.5

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
 From Version 7.0.100-1.22368.1 -> To Version 7.0.100-1.22377.1 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestro bot and others added 3 commits July 29, 2022 19:39
…220729.2

Microsoft.Dotnet.Sdk.Internal
 From Version 7.0.100-rc.1.22374.1 -> To Version 7.0.100-rc.1.22379.2

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
 From Version 7.0.100-1.22368.1 -> To Version 7.0.100-1.22377.1 (parent: Microsoft.Dotnet.Sdk.Internal
…220731.2

Microsoft.Dotnet.Sdk.Internal
 From Version 7.0.100-rc.1.22374.1 -> To Version 7.0.100-rc.1.22381.2

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
 From Version 7.0.100-1.22368.1 -> To Version 7.0.100-1.22377.1 (parent: Microsoft.Dotnet.Sdk.Internal
Context: dotnet/sdk#26627

This is triggering a bug in the dotnet/sdk.
jonathanpeppers and others added 5 commits August 1, 2022 16:10
…220802.10

Microsoft.Dotnet.Sdk.Internal
 From Version 7.0.100-rc.1.22374.1 -> To Version 7.0.100-rc.1.22402.10

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
 From Version 7.0.100-1.22368.1 -> To Version 7.0.100-1.22377.1 (parent: Microsoft.Dotnet.Sdk.Internal
@jonathanpeppers
Copy link
Member

jonathanpeppers commented Aug 3, 2022

This fails to build, must be something about the MSBuild argument parsing?

/Users/builder/azdo/_work/1/s/xamarin-android/bin/Release/dotnet/dotnet build -c Release -v:n  -bl:"/Users/builder/azdo/_work/1/s/xamarin-android//bin/BuildRelease/msbuild-`date +%Y%m%dT%H%M%S`-prepare-java.interop.binlog" Xamarin.Android.sln -t:PrepareJavaInterop

The fact this prints ` characters, makes me think something is wrong here?

@jonathanpeppers
Copy link
Member

Ok, now we're at:

/Users/runner/work/1/s/xamarin-android/src-ThirdParty/NUnitLite/Constraints/BinarySerializableConstraint.cs(57,17): error SYSLIB0011: 'BinaryFormatter.Serialize(Stream, object)' is obsolete: 'BinaryFormatter serialization is obsolete and should not be used. See https://aka.ms/binaryformatter for more information.' [/Users/runner/work/1/s/xamarin-android/src/Xamarin.Android.NUnitLite/Xamarin.Android.NUnitLite.NET.csproj]
/Users/runner/work/1/s/xamarin-android/src-ThirdParty/NUnitLite/Constraints/BinarySerializableConstraint.cs(61,32): error SYSLIB0011: 'BinaryFormatter.Deserialize(Stream)' is obsolete: 'BinaryFormatter serialization is obsolete and should not be used. See https://aka.ms/binaryformatter for more information.' [/Users/runner/work/1/s/xamarin-android/src/Xamarin.Android.NUnitLite/Xamarin.Android.NUnitLite.NET.csproj]

So must have to do something to opt into binary formatter now.

jonathanpeppers and others added 5 commits August 3, 2022 14:59
Context: https://github.com/dotnet/runtime/blob/197ae4c596553f7e6acb327ca2e31cc00c794c4d/src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/Formatters/Binary/BinaryFormatter.Core.cs#L11

Our build was failing with:

    src-ThirdParty/NUnitLite/Constraints/BinarySerializableConstraint.cs(57,17):
    error SYSLIB0011: 'BinaryFormatter.Serialize(Stream, object)' is obsolete: 'BinaryFormatter serialization is obsolete and should not be used. See https://aka.ms/binaryformatter for more information.'
    src-ThirdParty/NUnitLite/Constraints/BinarySerializableConstraint.cs(61,32):
    error SYSLIB0011: 'BinaryFormatter.Deserialize(Stream)' is obsolete: 'BinaryFormatter serialization is obsolete and should not be used. See https://aka.ms/binaryformatter for more information.'

I can add the same `[Obsolete]` messages on
`NUnit.Framework.Constraints.BinarySerializableConstraint` to solve
this error.
…220807.1

Microsoft.Dotnet.Sdk.Internal
 From Version 7.0.100-rc.1.22374.1 -> To Version 7.0.100-rc.1.22407.1

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
 From Version 7.0.100-1.22368.1 -> To Version 7.0.100-1.22377.1 (parent: Microsoft.Dotnet.Sdk.Internal
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The classic MSBuild test failed on provisionator, we probably don't need to rerun that one.

The designer tests failed with:

1) Invalid : D:/a/1/s/UITools/Designer/Xamarin.Designer.Android/Xamarin.AndroidDesigner.Tests/bin/Debug/Xamarin.AndroidDesigner.Tests.DLL
Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
  ----> Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.3.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
  ----> Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.3.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
  ----> Could not load file or assembly 'Microsoft.CodeAnalysis.Workspaces, Version=4.3.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
  ----> Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
  ----> Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
  ----> Could not load file or assembly 'Microsoft.CodeAnalysis.Workspaces, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

I assume this is unrelated, going to merge.

@jonathanpeppers jonathanpeppers merged commit ae178fa into main Aug 8, 2022
@jonathanpeppers jonathanpeppers deleted the darc-main-d18a9e18-18a2-4332-93c3-a4f391da93a1 branch August 8, 2022 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant