[ci] Upload test assemblies after signing #7241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently seen a handful of build timeouts and/or failures during
signing. The ESRP signing service seems to be much less performant and
more error prone on macOS. In these failure cases, rebuild attempts
would also fail when they got to the "upload test assembly step":
[error]Artifact test-assemblies already exists for build 6522654.
Improve this by uploading test assemblies and build inventory data at
the end of the build, and by increasing the overall timeout of the job.
jonathanpeppers
approved these changes
Aug 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently seen a handful of build timeouts and/or failures during
signing. The ESRP signing service seems to be much less performant and
more error prone on macOS. In these failure cases, rebuild attempts
would also fail when they got to the "upload test assembly" step:
Improve this by uploading test assemblies and build inventory data at
the end of the build, and by increasing the overall timeout of the job.