Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Upload test assemblies after signing #7241

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Aug 8, 2022

We've recently seen a handful of build timeouts and/or failures during
signing. The ESRP signing service seems to be much less performant and
more error prone on macOS. In these failure cases, rebuild attempts
would also fail when they got to the "upload test assembly" step:

[error]Artifact test-assemblies already exists for build 6522654.

Improve this by uploading test assemblies and build inventory data at
the end of the build, and by increasing the overall timeout of the job.

We've recently seen a handful of build timeouts and/or failures during
signing.  The ESRP signing service seems to be much less performant and
more error prone on macOS.  In these failure cases, rebuild attempts
would also fail when they got to the "upload test assembly step":

    [error]Artifact test-assemblies already exists for build 6522654.

Improve this by uploading test assemblies and build inventory data at
the end of the build, and by increasing the overall timeout of the job.
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the build is green. 👍

@pjcollins pjcollins merged commit 9b378e5 into dotnet:main Aug 9, 2022
@pjcollins pjcollins deleted the upload-last branch August 9, 2022 00:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants