[release/7.0.1xx-rc1] Update dependencies from dotnet/installer #7310
Conversation
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…220824.3 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22423.7 -> To Version 7.0.100-rc.1.22424.3 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref From Version 7.0.100-1.22415.4 -> To Version 7.0.100-1.22423.4 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestro
bot
requested review from
jonathanpeppers,
pjcollins and
jonpryor
as code owners
* Add feeds in `NuGet.config` from our .NET 6 release branch * Install both net6 & net7 workload manifests for Mono and Emscripten * Extend both net6 & net7 Mono workloads * Support for `$(AotAssemblies)` property (directly uses Mono workload pack names)
| "extends" : [ "microsoft-net-runtime-android", "microsoft-net-runtime-android-aot" ] | ||
| "extends" : [ | ||
| "microsoft-net-runtime-android-net6", | ||
| "microsoft-net-runtime-android-aot-net6", | ||
| "microsoft-net-runtime-android", | ||
| "microsoft-net-runtime-android-aot" | ||
| ] |
There was a problem hiding this comment.
@rolfbjarne you'll want to take similar changes here on the xamarin-macios side.
There was a problem hiding this comment.
@jonathanpeppers I ended up doing something slightly different, I split it in two different workloads: https://gist.github.com/rolfbjarne/4c9f93d892837a9b13e9cd577f8554a7#file-workloadmanifest-json-L3-L37 - although I'm not sure if that will cause any problems? Should I out everything in the ios workload instead?
There was a problem hiding this comment.
You might want to keep them all together for now. If you open a net6.0-ios project without a workload installed, this logic will prompt VS to install MAUI:
I don't think this code would work if there is an ios-net6 workload.
We might get them to rework this logic in .NET 7 RC 2, so that we can make the .NET 6 packs optional?
There was a problem hiding this comment.
OK, I'll look into changing that tomorrow.
There was a problem hiding this comment.
I've changed this in our cross/multi targeting PR for RC 1.
|
This is looking pretty green, I reran a couple phases. The |
…220824.4 Microsoft.Dotnet.Sdk.Internal From Version 7.0.100-rc.1.22423.7 -> To Version 7.0.100-rc.1.22424.4 Dependency coherency updates Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref From Version 7.0.100-1.22415.4 -> To Version 7.0.100-1.22423.4 (parent: Microsoft.Dotnet.Sdk.Internal
jonathanpeppers
deleted the
darc-release/7.0.1xx-rc1-f7b5e1cf-6bf3-4b35-a13a-74286993cc97
branch
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/installer
fixes #7252