Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Xamarin.Android.Build.Tasks] Make use we use UTC Dates for ResolveLibraryProjectImports.cs #768

Merged
merged 1 commit into from
Aug 23, 2017
Merged

[Xamarin.Android.Build.Tasks] Make use we use UTC Dates for ResolveLibraryProjectImports.cs #768

merged 1 commit into from
Aug 23, 2017

Conversation

dellis1972
Copy link
Contributor

We were not using UTC for allot of the date time comparisons in
the ResolveLibraryProjectImports.cs task. We really should be
since it means we should not hit any issues with LocalTimes.

@jonpryor
Copy link
Member

Test failure in AndroidUpdateResourcesTest.CheckDontUpdateResourceIfNotNeeded():

                                                MESSAGE:
                                                  _UpdateAndroidResgen target should be skipped.
  Expected: True
  But was:  False

                                                +++++++++++++++++++
                                                STACK TRACE:
                                                at Xamarin.Android.Build.Tests.AndroidUpdateResourcesTest.CheckDontUpdateResourceIfNotNeeded () [0x0021a] in <6e0fd2816ede445c8a12a8e61879da40>:0

@dellis1972
[Xamarin.Android.Build.Tasks] Make use we use UTC Dates for ResolveLi…
9d47497 
…braryProjectImports.cs

We were not using UTC for allot of the date time comparisons in
the `ResolveLibraryProjectImports.cs` task. We really should be
since it means we should not hit any issues with LocalTimes.
@jonpryor jonpryor merged commit 9204506 into dotnet:master Aug 23, 2017
jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Jan 6, 2021
@jonpryor
Bump to xamarin/Java.Interop/master@fdc200cc
a0ea50d 
Fixes: dotnet/java-interop#767

Changes: dotnet/java-interop@7574f16...fdc200c

  * dotnet/java-interop@fdc200cc: [Xamarin.Android.Tools.Bytecode] Relax _ApiXml check (dotnet#772)
  * dotnet/java-interop@f1b93653: [generator] Change generated code to not emit CA1305 warning. (dotnet#771)
  * dotnet/java-interop@2244407d: [generator] Ensure DIM from assembly refs are correctly marked (dotnet#770)
  * dotnet/java-interop@da73d6a5: [Java.Interop] Prevent premature collection w/ JniInstance* (dotnet#768)

Commit a7413a2 added support for invoking `java-source-utils.jar`
on `@(JavaSourceJar)` to extract Javadoc comments and translate them
into C# XML Documentation Comments.

What this can *also* do is provide correct parameter names.
As of commit a7413a2, the `BindingBuildTest.JavaSourceJar()`
integration test would emit the warning:

	obj/Debug/generated/src/Com.Xamarin.Android.Test.Msbuildtest.JavaSourceJarTest.cs(75,20):
	warning CS1572: XML comment has a param tag for 'name', but there is no parameter by that name

Commit dotnet/java-interop@fdc200cc allows `java-source-utils.jar`
output to be used with `class-parse`, allowing
`@(_JavaSourceJavadocXml)` files -- the output of
`java-source-utils.jar` -- to be included in
`@(_AndroidDocumentationPath)`.

This allows `@(JavaSourceJar)` files to provide parameter names
within bindings, removing the CS1572 warning, and making for
better overall bindings.
@jonpryor jonpryor mentioned this pull request Jan 6, 2021
Merged
jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Jan 6, 2021
@jonpryor
Bump to xamarin/Java.Interop/master@fdc200cc
01fcfed 
Fixes: dotnet/java-interop#767

Changes: dotnet/java-interop@7574f16...fdc200c

  * dotnet/java-interop@fdc200cc: [Xamarin.Android.Tools.Bytecode] Relax _ApiXml check (dotnet#772)
  * dotnet/java-interop@f1b93653: [generator] Change generated code to not emit CA1305 warning. (dotnet#771)
  * dotnet/java-interop@2244407d: [generator] Ensure DIM from assembly refs are correctly marked (dotnet#770)
  * dotnet/java-interop@da73d6a5: [Java.Interop] Prevent premature collection w/ JniInstance* (dotnet#768)

Commit a7413a2 added support for invoking `java-source-utils.jar`
on `@(JavaSourceJar)` to extract Javadoc comments and translate them
into C# XML Documentation Comments.

What this can *also* do is provide correct parameter names.
As of commit a7413a2, the `BindingBuildTest.JavaSourceJar()`
integration test would emit the warning:

	obj/Debug/generated/src/Com.Xamarin.Android.Test.Msbuildtest.JavaSourceJarTest.cs(75,20):
	warning CS1572: XML comment has a param tag for 'name', but there is no parameter by that name

Commit dotnet/java-interop@fdc200cc allows `java-source-utils.jar`
output to be used with `class-parse`, allowing
`@(_JavaSourceJavadocXml)` files -- the output of
`java-source-utils.jar` -- to be included in
`@(_AndroidDocumentationPath)`.

This allows `@(JavaSourceJar)` files to provide parameter names
within bindings, removing the CS1572 warning, and making for
better overall bindings.
jonpryor added a commit that referenced this pull request Jan 7, 2021
@jonpryor
Bump to xamarin/Java.Interop/master@fdc200cc (#5468)
0e95ec7 
Fixes: dotnet/java-interop#767

Changes: dotnet/java-interop@7574f16...fdc200c

  * dotnet/java-interop@fdc200cc: [Xamarin.Android.Tools.Bytecode] Relax _ApiXml check (#772)
  * dotnet/java-interop@f1b93653: [generator] Change generated code to not emit CA1305 warning. (#771)
  * dotnet/java-interop@2244407d: [generator] Ensure DIM from assembly refs are correctly marked (#770)
  * dotnet/java-interop@da73d6a5: [Java.Interop] Prevent premature collection w/ JniInstance* (#768)

Commit a7413a2 added support for invoking `java-source-utils.jar`
on `@(JavaSourceJar)` to extract Javadoc comments and translate them
into C# XML Documentation Comments.

What this can *also* do is provide correct parameter names.
As of commit a7413a2, the `BindingBuildTest.JavaSourceJar()`
integration test would emit the warning:

	obj/Debug/generated/src/Com.Xamarin.Android.Test.Msbuildtest.JavaSourceJarTest.cs(75,20):
	warning CS1572: XML comment has a param tag for 'name', but there is no parameter by that name

Commit dotnet/java-interop@fdc200cc allows `java-source-utils.jar`
output to be used with `class-parse`, allowing
`@(_JavaSourceJavadocXml)` files -- the output of
`java-source-utils.jar` -- to be included in
`@(_AndroidDocumentationPath)`.

This allows `@(JavaSourceJar)` files to provide parameter names
within bindings, removing the CS1572 warning, and making for
better overall bindings.

We can see the benefits of this change in
`tests/CodeGen-Binding/Xamarin.Android.JcwGen-Tests/BindingTests.cs`,
which required changes because the parameter names in the Java
`DataListener.onDataReceived()` method could now be determined;
previously they couldn't, resulting in the `P0`/`P1`/etc. names.
With the provision of `@(JavaSourceJar)` -- a7413a2 updated
`Xamarin.Android.McwGen-Tests.csproj` to have `@(JavaSourceJar)` --
the parameter names can now be determined, improving the binding.
jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Jan 15, 2021
@jonpryor
Bump to xamarin/Java.Interop/d16-9@d6d86b2c
2335a74 
dotnet/java-interop@1d382be...d6d86b2

  * dotnet/java-interop@d6d86b2c: [generator] Ensure DIM from assembly refs are correctly marked (dotnet#770)
  * dotnet/java-interop@20edccb4: [Java.Interop] Prevent premature collection w/ JniInstance* (dotnet#768)
@jonpryor jonpryor mentioned this pull request Jan 15, 2021
Merged
jonpryor added a commit that referenced this pull request Jan 17, 2021
@jonpryor
Bump to xamarin/Java.Interop/d16-9@d6d86b2c (#5510)
8608c5a 
dotnet/java-interop@1d382be...d6d86b2

  * dotnet/java-interop@d6d86b2c: [generator] Ensure DIM from assembly refs are correctly marked (#770)
  * dotnet/java-interop@20edccb4: [Java.Interop] Prevent premature collection w/ JniInstance* (#768)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dellis1972 @jonpryor @dnfclas