Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AndroidDependenciesTests] Use platform-tools 34.0.4 #8184

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

pjcollins
Copy link
Member

The InstallAndroidDependenciesTest test has been failing:

_AndroidSdkDirectory not set to new SDK path /Users/runner/work/1/a/TestRelease/07-11_21.59.53/temp/InstallAndroidDependenciesTest/android-sdk, probably because Google's repository has a newer platform-tools package!  repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>4</micro>; expected 34.0.3!

Fix this by bumping the platform-tools version that we try to install during this test to 34.0.4.

The `InstallAndroidDependenciesTest` test has been failing:

    _AndroidSdkDirectory not set to new SDK path /Users/runner/work/1/a/TestRelease/07-11_21.59.53/temp/InstallAndroidDependenciesTest/android-sdk, probably because Google's repository has a newer platform-tools package!  repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>4</micro>; expected 34.0.3!

Fix this by bumping the platform-tools version that we try to install
during this test to 34.0.4.
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, this seems fine for now. 👍

@@ -36,7 +36,7 @@ public void InstallAndroidDependenciesTest ()
var proj = new XamarinAndroidApplicationProject {
TargetSdkVersion = apiLevel.ToString (),
};
const string ExpectedPlatformToolsVersion = "34.0.3";
const string ExpectedPlatformToolsVersion = "34.0.4";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we could use HttpClient and pull the version out of a file?

Copy link
Contributor

@dellis1972 dellis1972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice not to have to bump this every few months/weeks.

@pjcollins pjcollins merged commit 8b613c2 into dotnet:main Jul 12, 2023
@pjcollins pjcollins deleted the pt3404 branch July 12, 2023 14:28
grendello added a commit to grendello/xamarin-android that referenced this pull request Jul 12, 2023
* main:
  [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
grendello added a commit to grendello/xamarin-android that referenced this pull request Jul 13, 2023
* typemap-per-rid-support:
  Address comments
  [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
grendello added a commit to grendello/xamarin-android that referenced this pull request Jul 14, 2023
* main:
  [Xamarin.Android.Build.Tasks] per-RID assemblies & typemaps (dotnet#8164)
  [AndroidDependenciesTests] Test both manifest types (dotnet#8186)
  [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
grendello added a commit to grendello/xamarin-android that referenced this pull request Jul 14, 2023
* main:
  [ci] XA.PublishAllLogs publishes all build logs to build artifacts (dotnet#8189)
  Bump to xamarin/Java.Interop/main@151b03e (dotnet#8188)
  [Mono.Android] Use PublicApiAnalyzers to ensure we do not break API. (dotnet#8171)
  [Xamarin.Android.Build.Tasks] per-RID assemblies & typemaps (dotnet#8164)
  [AndroidDependenciesTests] Test both manifest types (dotnet#8186)
  [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
grendello added a commit to grendello/xamarin-android that referenced this pull request Jul 17, 2023
* main:
  LLVM IR code generator refactoring and updates (dotnet#8140)
  [ci] XA.PublishAllLogs publishes all build logs to build artifacts (dotnet#8189)
  Bump to xamarin/Java.Interop/main@151b03e (dotnet#8188)
  [Mono.Android] Use PublicApiAnalyzers to ensure we do not break API. (dotnet#8171)
  [Xamarin.Android.Build.Tasks] per-RID assemblies & typemaps (dotnet#8164)
  [AndroidDependenciesTests] Test both manifest types (dotnet#8186)
  [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
jonathanpeppers pushed a commit that referenced this pull request Jul 17, 2023
The `InstallAndroidDependenciesTest` test has been failing:

    _AndroidSdkDirectory not set to new SDK path /Users/runner/work/1/a/TestRelease/07-11_21.59.53/temp/InstallAndroidDependenciesTest/android-sdk, probably because Google's repository has a newer platform-tools package!  repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>4</micro>; expected 34.0.3!

Fix this by bumping the platform-tools version that we try to install
during this test to 34.0.4.
jonpryor pushed a commit to jonpryor/xamarin-android that referenced this pull request Jul 26, 2023
The `InstallAndroidDependenciesTest` test has been failing:

    _AndroidSdkDirectory not set to new SDK path /Users/runner/work/1/a/TestRelease/07-11_21.59.53/temp/InstallAndroidDependenciesTest/android-sdk, probably because Google's repository has a newer platform-tools package!  repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>4</micro>; expected 34.0.3!

Fix this by bumping the platform-tools version that we try to install
during this test to 34.0.4.
jonpryor pushed a commit that referenced this pull request Jul 26, 2023
The `InstallAndroidDependenciesTest` test has been failing:

    _AndroidSdkDirectory not set to new SDK path /Users/runner/work/1/a/TestRelease/07-11_21.59.53/temp/InstallAndroidDependenciesTest/android-sdk, probably because Google's repository has a newer platform-tools package!  repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>4</micro>; expected 34.0.3!

Fix this by bumping the platform-tools version that we try to install
during this test to 34.0.4.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants