Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Trim Xamarin.Android.sln #8487

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[build] Trim Xamarin.Android.sln #8487

merged 1 commit into from
Nov 7, 2023

Conversation

pjcollins
Copy link
Member

Removes a handful of project references from Xamarin.Android.sln that
are no longer needed. Sources for a couple of obsolete build tools have
also been removed.

@pjcollins
[build] Trim Xamarin.Android.sln
1c7f1ba 
Removes a handful of project references from Xamarin.Android.sln that
are no longer needed.  Sources for a couple of obsolete build tools have
also been removed.
@pjcollins pjcollins marked this pull request as ready for review November 7, 2023 01:35
jonathanpeppers
jonathanpeppers approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two projects: proprietary and setup-windows are old, and pre-date 64-bit VS, so they probably don't even work anymore.

@pjcollins pjcollins merged commit 9808988 into main Nov 7, 2023
42 of 47 checks passed
@pjcollins pjcollins deleted the dev/pjc/trim-sln branch November 7, 2023 16:53
grendello added a commit that referenced this pull request Nov 8, 2023
@grendello
Merge branch 'main' into dev/grendel/blobs-in-lib
852eb02 
* main:
  [build] Trim Xamarin.Android.sln (#8487)
  [Tests] Fix Designer Tests to use ` AndroidSdkResolver.GetMaxInstalledPlatform ()` (#8488)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@jonpryor jonpryor Awaiting requested review from jonpryor jonpryor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjcollins @jonathanpeppers