Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Better support running on arm64-v8a devices #8492

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Nov 8, 2023

MSBuild device tests that specified a subset of supported ABIs can fail
depending on your target device/emulator. These tests have been updated
to use the default ABI of the attached device, which is determined
during test setup.

Tests which explicitly specify the full set of supported ABIs have been
left unchanged.

MSBuild device tests that specified a subset of supported ABIs can fail
depending on your target device/emulator.  These tests have been updated
to use the default ABI of the attached device, which is determined
during test setup.
@pjcollins pjcollins marked this pull request as ready for review November 8, 2023 22:32
Copy link
Contributor

@dellis1972 dellis1972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.
I do wonder if we need to make sure we have at least one test which runs an app which does have a full set of abis? The reasoning is to make sure we do not break abi detection in the fast dev process.

@pjcollins
Copy link
Member Author

Looks ok. I do wonder if we need to make sure we have at least one test which runs an app which does have a full set of abis? The reasoning is to make sure we do not break abi detection in the fast dev process.

We do still have a dozen tests or so in InstallAndRunTests and other classes that were explicitly setting support for all ABIs, I left those unchanged. We also have tests that don't modify the property at all.

We could also try to remove many of these supported ABI overrides now that main is .NET only, as our defaults there for both debug and release are more extensive.

@pjcollins pjcollins merged commit 1331aa2 into main Nov 10, 2023
47 checks passed
@pjcollins pjcollins deleted the dev/pjc/arm64-devtest branch November 10, 2023 20:31
grendello added a commit that referenced this pull request Nov 13, 2023
* main:
  [tests] Better support running on arm64-v8a devices (#8492)
  [Build Tasks] Import mono linker sources (#8482)
  [tests] update Microsoft.Intune.Maui.Essentials.android (#8495)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants