Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft.Android.Templates] docs link in binding project template #8535

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

jonathanpeppers
Copy link
Member

Fixes: #8411
Context: dotnet/docs-maui#1916

We have a nice docs page that should eliminate some confusion if we linked to it with a comment in the project template.

I considered putting a commented out example of disabling the C# binding (ala EmbeddedReferenceJar):

<ItemGroup>
  <AndroidLibrary Update="foo.jar" Bind="false">
</ItemGroup

But I think this case is rare, and the docs page should be sufficient.

Fixes: dotnet#8411
Context: dotnet/docs-maui#1916

We have a nice docs page that should eliminate some confusion if we
linked to it with a comment in the project template.

I considered putting a commented out example of disabling the C# binding
(ala `EmbeddedReferenceJar`):

    <ItemGroup>
      <AndroidLibrary Update="foo.jar" Bind="false">
    </ItemGroup

But I think this case is rare, and the docs page should be sufficient.
@jonpryor jonpryor merged commit 86eb5dc into dotnet:main Nov 29, 2023
47 checks passed
@jonathanpeppers jonathanpeppers deleted the AndroidBindingLink branch November 29, 2023 17:17
grendello added a commit that referenced this pull request Nov 30, 2023
* main:
  [Microsoft.Android.Templates] docs link in binding project template (#8535)
  Bump to mono/debugger-libs@84c5c67 (#8536)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document some examples in binding project template
4 participants