[tests] enable Xamarin.Android.LibraryProjectZip-LibBinding test #8588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#7794 * Port `Xamarin.Android.LibraryProjectZip-LibBinding.csproj` to .NET 9. * Update to a more recent gradle version, I chose the one MAUI is using: https://github.com/dotnet/maui/blob/3c7b65264d2f341a48db32263a271fd8718cfd23/src/Core/AndroidNative/build.gradle#L8 * Use `mavenCentral()` instead of `jcenter()` as the latter is deprecated. * Fix `Outputs` by running `<Touch Files="$(OutputPath)JavaLib.aar" />` This enables the last few tests in dotnet#7794.
|
The restored tests seem to be working:
|
grendello
added a commit
that referenced
this pull request
Jan 8, 2024
* main: [tests] fix `MAUI Integration` lane (#8614) [xaprepare] use `$(XAPackagesDir)` for NuGet folder (#8613) Add ApiScan to nightly build (#8605) Bump to dotnet/installer@29db8a1157 9.0.100-alpha.1.23628.5 (#8611) [Mono.Android] Fix ServerCertificateCustomValidator (#8594) Bump to dotnet/installer@e08874da58 9.0.100-alpha.1.23625.1 Bump to dotnet/installer@fae23c6571 9.0.100-alpha.1.23618.2 Localized file check-in by OneLocBuild Task (#8589) [tests] enable Xamarin.Android.LibraryProjectZip-LibBinding test (#8588)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7794
Port
Xamarin.Android.LibraryProjectZip-LibBinding.csprojto .NET 9.Update to a more recent gradle version, I chose the one MAUI is using:
https://github.com/dotnet/maui/blob/3c7b65264d2f341a48db32263a271fd8718cfd23/src/Core/AndroidNative/build.gradle#L8
Use
mavenCentral()instead ofjcenter()as the latter is deprecated.Fix
Outputsby running<Touch Files="$(OutputPath)JavaLib.aar" />This enables the last few tests in #7794.