[Xamarin.Android.Build.Tasks] introduce BannedApiAnalyzers for Mono.Cecil #8715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/dotnet/roslyn-analyzers/blob/68c643b4667c6808bd21910ef32f7e2f7bd776c5/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/BannedApiAnalyzers.Help.md
In 526172b, we had some reasonable performance wins just by using
TypeDefinitionCache
. Let's take this a step further by "banning" usage of:I applied this change to
Xamarin.Android.Build.Tasks.csproj
for now.In various places, I had to pass
TypeDefinitionCache
around or use an existing one.In a future PR, I'll make a small change in xamarin/java.interop so we can apply the same treatment to
Microsoft.Android.Sdk.ILLink.csproj
.