Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0.2xx] [build] keep $(DotNetAndroidManifestVersionBand) on 8.0.100 #8841

Merged
merged 2 commits into from
Mar 27, 2024
Merged

[release/8.0.2xx] [build] keep $(DotNetAndroidManifestVersionBand) on 8.0.100 #8841

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b53f16
[build] keep $(DotNetAndroidManifestVersionBand) on 8.0.100
jonathanpeppers Mar 27, 2024
c4cdaa4
Update Versions.props
jonathanpeppers Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
<DotNetMonoManifestVersionBand>8.0.100</DotNetMonoManifestVersionBand>
<DotNetEmscriptenManifestVersionBand>8.0.100</DotNetEmscriptenManifestVersionBand>
<!-- NOTE: sometimes we hardcode this when transitioning to new version bands -->
<DotNetAndroidManifestVersionBand>$(DotNetPreviewVersionBand)</DotNetAndroidManifestVersionBand>
<DotNetAndroidManifestVersionBand>8.0.100</DotNetAndroidManifestVersionBand>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing this used anywhere, should we update Microsoft.NET.Sdk.Android.proj to use this instead of $(DotNetSdkManifestsFolder)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying the other property now, (exactly what release/7.0.4xx has).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems to work:

image

But letting CI finish.

</PropertyGroup>
</Project>
Loading