[build] Remove make framework-assemblies target #9269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm often running `make leeroy` to test changes while building on macOS, and I noticed that an extra handful of Mono.Android.csproj builds were running each time. The `framework-assemblies` target that is declared in the generated `rules.mk` file includes some additional project builds that don't seem to be necessary in a .NET only world. The build has been updated to stop generating `rules.mk` entirely, and the make targets in `BuildEverything.mk` have been simplified.
grendello
approved these changes
Sep 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm often running
make leeroyto test changes while building on macOS,and I noticed that an extra handful of Mono.Android.csproj builds were
running each time. The
framework-assembliestarget that is declaredin the generated
rules.mkfile includes some additional project buildsthat don't seem to be necessary in a .NET only world.
The build has been updated to stop generating
rules.mkentirely, andthe make targets in
BuildEverything.mkhave been simplified.