Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xamarin.Android.Build.Tasks] Remove Xamarin.Analysis #9283

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Sep 4, 2024

Changes: https://github.com/xamarin/monodroid/compare/8bd4bae7e2961200dc342abf02b654efaf1d45d0...ae47dedcdb9d7cd83c18630b3941ecb4b9441d7c

Removes Xamarin.Analysis and Xamarin.Android.Analysis build tasks and
targets. The xamarin/xamarin-analysis repo has been archived, and the
only extension point for that build infrastructure in this repo appears
to be in Xamarin.Android.Analysis.targets which is now obsolete.

@pjcollins pjcollins changed the title Test Xamarin.Analysis removal [Xamarin.Android.Build.Tasks] Remove Xamarin.Analysis Sep 4, 2024
@pjcollins pjcollins marked this pull request as ready for review September 5, 2024 01:00
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge, as I saw some other PRs fail cloning xamarin analysis.

@jonathanpeppers jonathanpeppers merged commit c96f572 into main Sep 5, 2024
56 of 58 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/pjc/xanalysis branch September 5, 2024 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants