Update Trace dos with OSX instructions #9284
Conversation
dellis1972
requested review from
jonathanpeppers
and removed request for
jonpryor
|
|
||
| ```dotnetcli | ||
| dotnet restore foo.csproj | ||
| dotnet trace collect --format speedscope -- dotnet build "-t:Run" -bl --no-restore foo.csproj -p:UseSharedCompilation=false |
There was a problem hiding this comment.
If the -p:UseSharedCompilation=false works, do we not need the quotes around "-t:Run" anymore? Maybe that was a bug fixed at some point?
There was a problem hiding this comment.
The quotes for -t:Run never should have been needed. You'd need quotes if you wanted to specify multiple ;-separated targets, e.g. "-t:Restore;Run".
Now, it might be handy to have quotes anyway to make editing the command-line easier…. but as-is, the quotes here are not needed, and never were.
There was a problem hiding this comment.
…but then there's the subsequent paragraph, doh:
found that
"is necessary when:characters are present in the command. This appears to be some kind of argument parsing issue withdotnet trace.
So maybe the double-quotes are needed.
No description provided.