[build] fix incremental build for RuntimeLists.xml
#9327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 5ebcb1d, a new `libarchive-dso-stub.so` file was added to `Microsoft.Android.Runtime.proj` and runtime packs, but I started getting build failures for any app, such as: bin\Debug\lib\packs\Microsoft.Android.Sdk.Windows\35.0.0\tools\Xamarin.Android.Common.Debugging.targets(139,2): error XABLD7009: System.InvalidOperationException: Internal error: archive DSO stub location not known for architecture 'Arm64' at Xamarin.Android.Tasks.DSOWrapperGenerator.WrapIt(AndroidTargetArch targetArch, String payloadFilePath, String outputFileName, IBuildEngine4 buildEngine, TaskLoggingHelper log) in src\Xamarin.Android.Build.Tasks\Utilities\DSOWrapperGenerator.cs:line 86 at Xamarin.Android.Tasks.BuildApk.AddRuntimeConfigBlob(ZipArchiveEx apk) in src\Xamarin.Android.Build.Tasks\Tasks\BuildApk.cs:line 408 at Xamarin.Android.Tasks.BuildApk.ExecuteWithAbi(String[] supportedAbis, String apkInputPath, String apkOutputPath, Boolean debug, Boolean compress, IDictionary`2 compressedAssembliesInfo, String assemblyStoreApkName) in src\Xamarin.Android.Build.Tasks\Tasks\BuildApk.cs:line 215 at Xamarin.Android.Tasks.BuildApk.RunTask() in src\Xamarin.Android.Build.Tasks\Tasks\BuildApk.cs:line 357 at Microsoft.Android.Build.Tasks.AndroidTask.Execute() in external\xamarin-android-tools\src\Microsoft.Android.Build.BaseTasks\AndroidTask.cs:line 25 Reviewing a build log and files on disk, I saw this line was missing from `RuntimeList.xml`: <File Type="Native" Path="runtimes/android-x64/native/libarchive-dso-stub.so" FileVersion="0.0.0.0" Profile="Android" /> This causes the build to not include the `.so` file, as this is the general logic for .NET workloads and runtime packs. To fix this, we need to change the `Inputs` of the `CreateLocalRuntimeLists` target that generates this file: --$(MSBuildThisFile) ++$(MSBuildAllProjects) This way if `Microsoft.Android.Runtime.proj` changes in the future, the targets will run. I also fixed `CreateLocalFrameworkLists` for `FrameworkList.xml`.
dellis1972
approved these changes
Sep 25, 2024
pjcollins
approved these changes
Sep 25, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
APK tests have some networking failures: Otherwise looks green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 5ebcb1d, a new
libarchive-dso-stub.sofile was added toMicrosoft.Android.Runtime.projand runtime packs, but I started getting build failures for any app, such as:Reviewing a build log and files on disk, I saw this line was missing from
RuntimeList.xml:This causes the build to not include the
.sofile, as this is the general logic for .NET workloads and runtime packs.To fix this, we need to change the
Inputsof theCreateLocalRuntimeListstarget that generates this file:This way if
Microsoft.Android.Runtime.projchanges in the future, the targets will run.I also fixed
CreateLocalFrameworkListsforFrameworkList.xml.