[tests] skip performance tests (w/ .apk changes) on non-commercial builds
#9328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…builds Some of the `PerformanceTest` would result in `<BuildApk/>` running for non-commercial (open source) builds and *skipped* in commercial builds. This makes the build much slower, and the test will likely fail on PRs from forks. For now, let's skip these specific tests for non-commercial builds.
dellis1972
approved these changes
Sep 25, 2024
pjcollins
approved these changes
Sep 25, 2024
|
Looks like they are skipping correctly:
Going to merge, so this can fix other PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the
PerformanceTestwould result in<BuildApk/>running for non-commercial (open source) builds and skipped in commercial builds. This makes the build much slower, and the test will likely fail on PRs from forks.For now, let's skip these specific tests for non-commercial builds.