Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mapping of generic xref's to cref's #72

Closed
wants to merge 4 commits into from

Conversation

eiriktsarpalis
Copy link
Member

Related to #71. Addresses an issue in the xref mapping logic where generics with multiple parameters are not handled properly.

cc @carlossanlop @jeffhandley

@eiriktsarpalis
Copy link
Member Author

The test failure is linux specific and is likely tooling related. I use preview 2 and it fails with the following error:

Diagnostic messages found in workspace.OpenProjectAsync - /tmp/fj5lf5d1.mnu/Project/MyAssembly.csproj:
    Failure - Msbuild failed when processing the file '/tmp/fj5lf5d1.mnu/Project/MyAssembly.csproj' with message: The expression "[MSBuild]::GetTargetFrameworkIdentifier(net5.0)" cannot be evaluated. MSB0001: Internal MSBuild Error: A required NuGet assembly was not found. Expected Path: /home/eirik/devel/dotnet/runtime/.dotnet/sdk/6.0.100-preview.2.21155.3  /home/eirik/devel/dotnet/runtime/.dotnet/sdk/6.0.100-preview.2.21155.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets

However reverting the projects to net5.0 makes the issue go away.

<format type="text/markdown">
<![CDATA[
## Remarks
Here's a reference to <xref:MyNamespace.MyGenericType.Select%60%602%28MyNamespace.MyGenericType%7B%60%600%7D%2CSystem.Func%7B%60%600%2C%60%601%7D%29>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants