Skip to content

Commit

Permalink
Add back the quotes to sdl configuration (#8074)
Browse files Browse the repository at this point in the history
When the code for running the configure step in sdl validation was moved, the quotes were removed from the tool args. This prevents us from upgrading the version of guardian, because newer versions of guardian get confused by the triangle brackets. This change adds back the quotes around each tool arg.
  • Loading branch information
michellemcdaniel authored Oct 21, 2021
1 parent cb683d5 commit 76b53a1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions eng/common/sdl/configure-sdl-tool.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,13 @@ try {
# For some tools, add default and automatic args.
if ($tool.Name -eq 'credscan') {
if ($targetDirectory) {
$tool.Args += "TargetDirectory < $TargetDirectory"
$tool.Args += "`"TargetDirectory < $TargetDirectory`""
}
$tool.Args += "OutputType < pre"
$tool.Args += "`"OutputType < pre`""
$tool.Args += $CrScanAdditionalRunConfigParams
} elseif ($tool.Name -eq 'policheck') {
if ($targetDirectory) {
$tool.Args += "Target < $TargetDirectory"
$tool.Args += "`"Target < $TargetDirectory`""
}
$tool.Args += $PoliCheckAdditionalRunConfigParams
}
Expand Down

0 comments on commit 76b53a1

Please sign in to comment.