Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor eng\validate-sdk.ps1 #2197

Closed
JohnTortugo opened this issue Mar 8, 2019 · 4 comments
Closed

Refactor eng\validate-sdk.ps1 #2197

JohnTortugo opened this issue Mar 8, 2019 · 4 comments
Assignees

Comments

@JohnTortugo
Copy link
Contributor

We should consider changing the approach used by [validate-sdk.ps1](https://github.com/dotnet/arcade/blob/65820ecd54acd04013f95f2635c284459ba2c273/eng/validate-sdk.ps1#L86) where it moves the whole artifacts\ folder. This is causing a lot of interference with things that run after the script.

@chcosta @riarenas @alexperovich

@chcosta
Copy link
Member

chcosta commented Mar 8, 2019

@JohnTortugo
Copy link
Contributor Author

@riarenas just FYI, this is the reason we have those copy files around in PushToAzureDevOpsArtifacts: https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Build.Tasks.Feed/src/PushToAzureDevOpsArtifacts.cs#L75

@chcosta
Copy link
Member

chcosta commented Aug 28, 2019

This is removed in #3530 where we just do the "validate-sdk" type work in a different stage and we no longer copy the artifacts folder around.

@JohnTortugo
Copy link
Contributor Author

That's all I wanted to hear :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants