Break Arcade Build, Test, Validate SDK into stages #3530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Pull request contains merge conflicts. |
chcosta
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JohnTortugo
reviewed
Aug 14, 2019
mmitche
reviewed
Aug 16, 2019
mmitche
reviewed
Aug 16, 2019
mmitche
reviewed
Aug 16, 2019
mmitche
reviewed
Aug 16, 2019
mmitche
approved these changes
Aug 16, 2019
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I'll merge this in the morning just so I'm around to respond if this causes pain for anyone taking an Arcade update. |
|
Does it make sense to wait until P9 in out? |
|
Sounds like a good plan to me. There's nothing motivating merging this sooner. |
|
I'm going to wait to merge this until after @JohnTortugo has merged his change and he and @mmitche have clean builds. |
JohnTortugo
approved these changes
Sep 6, 2019
riarenas
added a commit
to riarenas/arcade
that referenced
this pull request
Sep 19, 2019
…)" This reverts commit b764063.
riarenas
added a commit
that referenced
this pull request
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR validation build - https://dev.azure.com/dnceng/public/_build/results?buildId=308614&view=results
Internal validation build - https://dev.azure.com/dnceng/internal/_build/results?buildId=308617&view=results
A couple of things to note:
@sunandabalu, @JohnTortugo, I changed how the post-build "dependsOn" stuff was evaluated. It appeared that the dependsOn was being passed either as a string, or with an array syntax. ie,
dependsOn: buildordependsOn: [build]. The first syntax doesn't permit you to specify multiple dependent jobs / stages. The second syntax looks nice, but (in my testing) seemed to only evaluate one of the dependent jobs, not all of them. I only call this out as an awareness thing when writing yaml.it appears that dependsOn is case-sensitive so I continued with the current naming pattern (pascal cased)
This change decreases official build time by 10+ minutes because we can run the "validate sdk" stage in parallel with the "post-build validate" stage instead of serializing the stages. I don't notice any significant impact to PR times (positive or negative) with moving artifacts between stages.
This change uses hosted pools for the Test stage, so we free up BYOC machines in the PR builds about 10 minutes earlier.
Removing "helix" telemetry, but leaving the "enableTelemetry" option because of Set the DOTNET_CLI_TELEMETRY_PROFILE environment variable #2688
Deprecating the "enablePublishBuildArtifacts" "enablePublishBuildAssets" parameters with an "artifacts" parameter which permits more control over what / how artifacts are published / downloaded.
The "artifacts" parameter is our supported way for moving artifacts between stages (for Arcade builds). It would be great if the "PackageArtifacts" stuff used the same artifacts rather than doing an additional upload - @JohnTortugo, I'll file an issue about this.
@alexperovich , changed
_BuildConfigtoConfigurationinUnitTests.projbecause_BuildConfigis supposed to be a yaml only concept and is intended to not interfere with any MSBuild or other build-time code.