-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the 'latest' links with something more sturdy #3963
Comments
-The copy strips off the version info of the file
+The copy strips off the version info of the blob name
Not true for Core-Setup. The dev would also have to configure their random branch to have a default assignment to the BAR channel associated with the dotnetcli 'latest' channel. Can't speak for other repos' implementations.
It sounds like Core-Setup would need to change to use Arcade's blob publish infra. (The implementation ended up custom because the functionality arrived in Arcade too late.) Is this true? That said, I agree this sounds like a good approach to enable stable links with Arcade publishing. |
I think so? Certainly for .NET 5 the combined repo should use arcade's implementation, which means it will happen transparently. For .NET 3.x, it would still be good to get on a common publish infra, now that the infra is available in arcade. |
Right, this is mainly a problem for core-sdk |
What "typically" does this copying? With ASP.NET Core using the basic Arcade post-build infrastructure, are we affected at all? (Our customizations are fairly localized and don't extend to added stages or anything of that ilk.) |
I believe "latest" channel publishing stopped working for ASP.NET Core at some point and it's no longer done by anything for that repo: dotnet/aspnetcore#6509, dotnet/aspnetcore#6955. |
@dougbu core-sdk and core-setup. I think aspnetcore is not affecting and will just gain from automatic aka.ms links |
@mmitche any progress on your proposal? We just removed our download table in dotnet/runtime because the links were outdated since the consolidation. |
It keeps getting pre-empted and back-burnered. I'll see whether I can dig up some more time this week. |
I've gone ahead and added the issue template to the desc, with this:
The download table is the only reasonable way for external dotnet/runtime contributors to get the signed daily runtime installers. |
The latest link in various repos point to blobs in various repos based on the latest build. This is typically done by copying the build output to a set of -latest- files in blob storage.
This is a bad practice for a number of reasons:
Instead, what we should do is:
This would redirect to the target blob location. At the same time, this also gives us an an opportunity to generate a README.md which could be checked into a repo, update a web page, etc.
This should be simple to implement and no changes should be required in the repos (though they can remove their existing latest copy steps when dependent systems are updated)
The text was updated successfully, but these errors were encountered: