Uptake validation channel name changes to fix official build #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, I got some time to work on the aka.ms link this week, getting closer. |
mmitche
reviewed
Jan 17, 2020
|
For future reference Variable names come from here: windowsdesktop/eng/common/templates/post-build/common-variables.yml Lines 16 to 18 in 322773a Job ids come from here: windowsdesktop/eng/common/templates/post-build/post-build.yml Lines 153 to 155 in 322773a |
mmitche
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397
In dotnet/runtime we removed this infra to stop getting these breaking changes. This means the readme doesn't get updated, we're depending on dotnet/arcade#3963 to set those up again. Consider doing the same here.
/cc @NikolaMilosavljevic @RussKie @vatsan-madhavan @MichaelSimons