Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock MSbuild to onboard to V3 #7255

Closed
1 of 2 tasks
epananth opened this issue Apr 15, 2021 · 7 comments
Closed
1 of 2 tasks

Unblock MSbuild to onboard to V3 #7255

epananth opened this issue Apr 15, 2021 · 7 comments
Assignees

Comments

@epananth
Copy link
Member

epananth commented Apr 15, 2021

  • This issue is blocking
  • This issue is causing unreasonable pain

Update maestro task version in arcade so that msbuild can on board to V3 publishing

@epananth epananth self-assigned this Apr 15, 2021
@MattGal
Copy link
Member

MattGal commented Apr 15, 2021

[Async Triage] @epananth since you've self assigned this one, can it go into your current epic?

@epananth epananth changed the title Update Maestro task version to unblock msbuild Unblock MSbuild to onboard to V3 Apr 15, 2021
@epananth
Copy link
Member Author

In this fix, we will force Publishing.props to send the value for the azure repo uri.

@epananth epananth removed their assignment Apr 15, 2021
@MattGal MattGal self-assigned this Apr 22, 2021
@MattGal
Copy link
Member

MattGal commented Apr 27, 2021

Ooops, I didn't notice this one, but I already did most of the stuff in https://github.com/dotnet/core-eng/issues/12875.

The work is mostly done, but SourceLink broke expectedly as noted dotnet/msbuild#6375 . Since this translation happens in Arcade, I'm exploring workarounds. It will either be:

  • Try setting the ScmRepositoryUrl to the GitHub path in the build and turn off translation, so this is honored by the Source Link stuff
  • Teach Arcade's regex stuff to translate devdiv.visualstudio URLs back to the proper one (this seems like a waste as this is the only repo building from devdiv.vs right now, but possible)

@MattGal
Copy link
Member

MattGal commented Apr 28, 2021

Explored setting ScmRepositoryUrl in directory.build.props but it didn't work, so just added understanding of devdiv.visualstudio to the regex.

MattGal added a commit to MattGal/arcade that referenced this issue Apr 28, 2021
@MattGal
Copy link
Member

MattGal commented Apr 28, 2021

Once the release/5.0 port of the sourcelink fix merges, I'll close this as that will be the last known issue falling out of the move from github source.

MattGal added a commit that referenced this issue Apr 28, 2021
@MattGal
Copy link
Member

MattGal commented Apr 28, 2021

PR merged, optimistically closing this issue ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants