Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1 and 5.0 staging builds should have correct permissions for staging feeds #8527

Closed
2 tasks
mmitche opened this issue Mar 1, 2022 · 5 comments
Closed
2 tasks
Assignees
Labels
External Dependency Used to track FR issues for services that are not directly owned by DNCEng Ops - First Responder

Comments

@mmitche
Copy link
Member

mmitche commented Mar 1, 2022

  • This issue is blocking
  • This issue is causing unreasonable pain

The 3.1 and 5.0 staging pipelines create feeds for testing. These feeds are getting permissions that only allow contributors to see the contents. I think the issue is that this should be backported to 3.1 and 5.0:

#8082

@ilyas1974 ilyas1974 added Needs Triage A new issue that needs to be associated with an epic. and removed Ops - First Responder labels Mar 18, 2022
@michellemcdaniel michellemcdaniel self-assigned this Mar 29, 2022
@michellemcdaniel
Copy link
Contributor

This might be more complicated than we think it is because the 3.1 and 5.0 staging pipelines version of arcade will need to be updated, and likely require changes in a bunch of publishing code. 3.1 might be easy. 5.0 definitely will not be.

@michellemcdaniel
Copy link
Contributor

michellemcdaniel commented Mar 31, 2022

5.0 merge main into release/5.0 branch. Will get us this and alllllll the goodness we've put into production (sbom, retention, various publishing changes, and this change). PR: https://dev.azure.com/dnceng/internal/_git/dotnet-release/pullrequest/22092

servcing I am still working on and to upgrade arcade, I had to do some other shenanigans, but it was stuff that wasn't be used anyway, so I think it's ok to disable.

@ilyas1974 ilyas1974 added External Dependency Used to track FR issues for services that are not directly owned by DNCEng and removed Needs Triage A new issue that needs to be associated with an epic. labels Mar 31, 2022
@michellemcdaniel
Copy link
Contributor

changes for 5.0 have been checked in. Changes for 3.1 don't seem to be working at all. @mmitche how important is it that 3.1 has this?

@mmitche
Copy link
Member Author

mmitche commented Apr 21, 2022

changes for 5.0 have been checked in. Changes for 3.1 don't seem to be working at all. @mmitche how important is it that 3.1 has this?

Not that important. It's more annoying than anything else.

@michellemcdaniel
Copy link
Contributor

Based on that, I am going to close this issue and skip the 3.1 changes, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Dependency Used to track FR issues for services that are not directly owned by DNCEng Ops - First Responder
Projects
None yet
Development

No branches or pull requests

4 participants