Fix feed creation for dnceng-stage and staging scenarios #8082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
- Don't call GetFeedVisibilityTag when the feed name is explicitly specified - Alter GetFeedVisibilityTag to support non-dnceng - Alter the default permissions setup method to specify null permissions for non-dnceng
| @@ -55,7 +55,9 @@ public AzureDevOpsArtifactFeed(string name, string organization, string project) | |||
| } | |||
| break; | |||
| default: | |||
| throw new NotImplementedException($"Organization '{organization}' contains no feed permissions information."); | |||
| // Use the default permissions | |||
| Permissions = null; | |||
There was a problem hiding this comment.
@jonfortescue can you take a look at this bit? My recollection is that you changed some stuff around permissions for dnceng-stage, and I want to make sure this captures the change you had made
There was a problem hiding this comment.
The previous implementation of this had no permissions setup for anything but dnceng, so this effectively goes back to that: https://github.com/dotnet/arcade/pull/7700/files
There was a problem hiding this comment.
Yep, this looks fine to me -- this is exactly how it's supposed to be.
michellemcdaniel
approved these changes
Oct 22, 2021
jonfortescue
approved these changes
Oct 22, 2021
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check: