Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new WASI RID #11641

Merged
merged 2 commits into from
Nov 16, 2022
Merged

new WASI RID #11641

merged 2 commits into from
Nov 16, 2022

Conversation

pavelsavara
Copy link
Member

To complement adding new RID for compiling Mono to WebAssembly System Interface platform.

See also dotnet/runtime#78376 and dotnet/runtime#77780

@jkotas
Copy link
Member

jkotas commented Nov 15, 2022

WASI -> Wasi to make it match dotnet/runtime#78389 ?

@pavelsavara
Copy link
Member Author

WASI -> Wasi to make it match dotnet/runtime#78389 ?

That was after API people feedback.
There was feedback in opposite direction from @vargaz here dotnet/runtime#78376 (comment) so I made it uppercase WASI in that PR in most places. Should we reconsider ?

I don't have strong preference either way.

@akoeplinger
Copy link
Member

I'd use Wasi for the TestPlatforms enum for consistency, we can use WASI in the non-.NET build/project files.

@radical
Copy link
Member

radical commented Nov 16, 2022

cc @lewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants