Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Special Casing of RemoteExecutor Detection for Single File #12348

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Remove Special Casing of RemoteExecutor Detection for Single File #12348

merged 1 commit into from
Mar 16, 2023

Conversation

ivdiazsa
Copy link
Member

This PR removes the special case of RemoteExecutor detection in IsSupported(). The reason for this is that in dotnet/runtime's PR #80946 (dotnet/runtime#80946), we are setting the DOTNET_REMOTEEXECUTOR_SUPPORTED Environment Variable to 0, and since IsSupported() here looks for the aforementioned variable to be different from 0, then the RemoteExecutor detection became redundant.

This PR is expected to be merged after the one in dotnet/runtime.

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I've put a no merge label. This must not merge before your runtime repo change. There's no urgency in merging this - we should just not forget to do this at some point.

@ivdiazsa
Copy link
Member Author

It's been a bit. Should we merge this now @MichalStrehovsky?

@MichalStrehovsky MichalStrehovsky merged commit 182bc19 into dotnet:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants